New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support specPattern, deprecate integrationFolder and componentFolder #19168
Closed
Closed
Changes from 86 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
e020e7d
use new specPattern API
lmiller1990 df3d841
remove projectApi.findSpecs
lmiller1990 acfaf68
do not require integration folder
lmiller1990 7c21ce3
support --spec
lmiller1990 f380d09
support --spec
lmiller1990 38578c6
remove old code
lmiller1990 09f6c6d
remove old code
lmiller1990 f94acf5
nuke old code
lmiller1990 692247b
no appvetor
lmiller1990 9db1091
update
lmiller1990 7b081a9
correct url for ct
lmiller1990 3947f26
work on migrating launchpad
lmiller1990 9933ea5
update ct spec url
lmiller1990 8db54d0
types
lmiller1990 2ca354b
types
lmiller1990 97a4a00
dead code
lmiller1990 de7a624
remove old endpiont
lmiller1990 2a801eb
revert back circle.yml
lmiller1990 983c2c4
update missing config
lmiller1990 b39953a
delete spec util
lmiller1990 99eaace
update config
lmiller1990 d48b274
update config
lmiller1990 218fb5d
config again
lmiller1990 882a06e
update spec pattern
lmiller1990 1391927
updated vue config
lmiller1990 8551796
update spec pattern for ui components
lmiller1990 102376e
update config for vite dev server
lmiller1990 bc9629d
update snapshots
lmiller1990 a88ee2b
update config
lmiller1990 9ca7b81
update design system config
lmiller1990 935aa5d
fix spec pattern in reporter
lmiller1990 1aef8e1
update default
lmiller1990 2191d77
update deprecated spec snapshots
lmiller1990 839cf37
update system tests
lmiller1990 5996dad
update run mode output
lmiller1990 22c7d3f
revert changes
lmiller1990 f6560f1
lint
lmiller1990 a4da5a3
remove scaffold tests
lmiller1990 fc8dbf7
update angular
lmiller1990 5b3bbc0
fix CT
lmiller1990 31babca
update circle yml
lmiller1990 c869729
fix system tests for ct
lmiller1990 d9adbc5
fix tests
lmiller1990 9c01414
work on server unit tests
lmiller1990 2123ef9
patch package
lmiller1990 8f0db6b
patch package again
lmiller1990 4455ca7
update test
lmiller1990 79a0108
try not to rely on config async loading too much
lmiller1990 e7f12d7
normalize specPattern to array
lmiller1990 c9947b8
update snapshot
lmiller1990 0b67c75
use base name
lmiller1990 1cf0e45
deal with react-scripts later
lmiller1990 74fb541
update snapshot
lmiller1990 fb7031e
hacky way to update snapshots
lmiller1990 3c2ea90
new hack to update snapshots
lmiller1990 68bb637
trying again
lmiller1990 aea7bcc
hacky fix
lmiller1990 5cf09ad
ci: snapshots
lmiller1990 eebc039
ci: snapshots
lmiller1990 aa03810
Merge branch 'lmiller1990/update-spec-pattern' of github.com:cypress-…
lmiller1990 221827d
snapshots
lmiller1990 3448071
mas updates
lmiller1990 b53c3bd
update spec API
lmiller1990 f3dc609
fix test
lmiller1990 a211290
fix test
lmiller1990 c01c219
update
lmiller1990 cee1f11
update test
lmiller1990 f3b6a53
fix test
lmiller1990 f80ddac
update plugin
lmiller1990 21303cf
update spec
lmiller1990 38b6504
webpack optinos
lmiller1990 53e3289
Update launchpad tests
estrada9166 a08efa7
fix screenshot paths
lmiller1990 a620654
Merge branch 'lmiller1990/update-spec-pattern' of https://github.com/…
lmiller1990 052bf82
merge in origin/10.0-release
lmiller1990 283ca1b
updated snapshot
lmiller1990 300ef6f
change pattern
lmiller1990 5e03714
guard
lmiller1990 fb215eb
fix smoke test
lmiller1990 30d3455
patch code coverage
lmiller1990 a62098c
update percy config
lmiller1990 0455aea
fix specs
lmiller1990 0f95501
try updating example project
lmiller1990 d24a522
update snapshots
lmiller1990 cd6c7be
remove old test
lmiller1990 23465e7
remove snapshot hack
lmiller1990 1d7ed8c
add back appveyor
lmiller1990 9c7b809
remove old code
lmiller1990 db12ca6
update snapshot
lmiller1990 84aac5e
Fix tests
estrada9166 ced245e
merge in origin
lmiller1990 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,105 +0,0 @@ | ||
branches: | ||
only: | ||
- master | ||
- develop | ||
- windows-code-signing | ||
- 10.0-release | ||
- /win*/ | ||
|
||
# https://www.appveyor.com/docs/lang/nodejs-iojs/ | ||
environment: | ||
# use matching version of Node.js | ||
nodejs_version: "16.5.0" | ||
# encode secure variables which will NOT be used | ||
# in pull requests | ||
# https://www.appveyor.com/docs/build-configuration/#secure-variables | ||
# the variables can be encrypted at | ||
# https://ci.appveyor.com/tools/encrypt | ||
ci_json: | ||
secure: uOM7Bj+6MfQA/wiUzA4MolZDlcdhIqrOWLN0LdR+Lg4olc1onF3IpWfRf+3B6Q5uT98OTnIU71OOqSRY7inGQg== | ||
# for uploading built binary to S3 bucket | ||
aws_credentials_json: | ||
secure: ttGzd2/rW+i8H+pozcFxzZKU07B5INL8+LjD4vCOKes+tI6EaKhrLvAQ9xT7r+e1p8My8f4LrqvT+i37kbRCUPY4DHmUgagj3aj0OghsT0eX/Vr/6T4v1yndB7SX7FnG07eVcGb63r9f5kT7xu7ElJ9WXh1Ok5K69W0zDPsa1RGCCYqsTi4tH2h5EAZwjY1b | ||
# CDN control | ||
CF_TOKEN: | ||
secure: nVGxcWxXGvrT621HmgMf9Mwm84dqo+cKHZj94OvyyWEGIZOJJkbWHsD/l2/r4a6Y | ||
CF_ZONEID: | ||
secure: SrZnd4BYW9PILEEi7y9VyXuC16C+qMEDT3QuV1PZZJa47TRkjcaYpAXhAHz0j0jT | ||
# authenticate as Cypress bot when posting commit status checks | ||
GH_APP_ID: | ||
secure: oR0RVDbv6GKej4wwjkz7Zw== | ||
GH_INSTALLATION_ID: | ||
secure: tAoqu4zIgZUxOfW0u9YQgw== | ||
GH_PRIVATE_KEY: | ||
secure: msLmlIBnkNovqrqTeCqa7ZPjETyS8Xn4JLuiRMWYK7gZBTO66pNnFaoeqwPFwH+ooO0cDFhAOPTToLisgTLXCo4hnw38zuBuKq+ywCh5mtk5uZn4x4F8G2XyRLD/ViZm+VuD2yZzaTWF11upDqC4xbXDe32yD6OSLKhA5ms5F5ke83zEuWSLTqVVCIpVH12rVTJHl3QHaWPwZbBBE3SFN8D6uiclvI06y3pEg2bVShU8YqlwearYTRuErsYXNCUmT0SrDd2kHznlYf08edQDHpydnQvvTViZMgomvYp5wDCXFD+/FxtTMuTptJFpspirXL8w/xjYy1/JaTd/K01oUUD2Xwl/v0cS28OpdcraETyrQxQhEgTCXfg9ONbZ5mRvQlkaRROaTqDSGMmEPs4N91zarpA7RLxu7PPvxXQcbDW4GiJvH5BhVWu8lY/QBZsr8It1dhLYSzTPNIh9ey8xNaUbZ3oQhPBoreRi36B+FSPBsrZpB8Q8aa97gd+lCa8br2RfaEpzx8gA0pSK44odqcGuJe7T8MHOqYo0cUEUb2UypPPG7mWyjGip+x3Z9P/vSrZzDV+YFFvEzQAMoyRMp/456V+YL8iduryMRIadkJcB4ZVZz2hsxY5Gv6Eeh9NhwzyM64Rz5NP5fJ9Kw8E5Vm+ddEmft8Ec6dajcURoVN0i+s8t7h/e3Hzrr62UjWr0FpUx5fPBC/Tldn3+h4Rr9/HFI2RCZAI5wHOrx/aQ/HknA9UCEdqdod8ix5yAdSpTxp3aCGEoS97STXU43CjLEiQFyLaReoHOOwFp5EqaAiAqiORJaKuShWoir+OqSk7rucU7kFvIlU9GDfLuKUpxcQoDq/8fKT3lcG3Pr4MVV79BJ6EcjcsEf4ukQ3IfwMY+2RbwYWEowsQP18k4HztZpMEOuYPlSCiAPL7Cz4dcE5oybSURr9QQbSqVMoiCKZBn344KxpvH59KW90wt8CYyoeLSlPpM9s73g9My4fwbB3W9lcbw/AteRGer01VYEHY+1MyQwhqgHoXQ//op4gztFbpSLcli88v1IOopcr0Dw5NrylcjCTKuVWmQs0uIAfOr7zxqCZ8DCXG6spdipjF1jx+bxp318ZgH56pmmTOTMbj5Cmdpr3KlCFbYB4JI7lexnZmti1NcHtOglDSq+XT4092myAiarSzQLA6smB+gk68M50W492+QNuc+6LAOfev+Da4geLiErqMpuIqfA3jw4h5+9Ns6mf3JnOLZd1c/X/xvnV3JjBzSJ6f9xGMLBcMTQm/wVfkHM9tO1oZrHswDiBlE1AkQrj6kqT9Kznu/rbAUGRnWL65FoCwdMbYVEhQQvLbLvVCRGBJfB01oD2xs80jyZ2YYZFRZCl/d0lGrVVVZsq6XM7CsxR5WlpJy5JLxCQ4kliG8cjexh0GkVYJoRYneJifw8yThMlyAnMQ88iNS2p2MnYk0WZgTJOIHliIhPRFY4z6BtrxmL8SR1no1vhaQCdbE5RI/rYbk8NpOmQunkjcDwp7nTKn1d8bMTfKGUH+DzhvmqwxA5PW37P84FFSK+3ePY9+oKXcInkAaxiXUpzcZJ4KzUGEZaZCB6irU+sxs6QLDzsq05PprwVz2DGtEn1TcY8qQ6ezeMGxJMRgDvEGq2J0nEgOEZ98CJ7XiPJRlnvUjGUzBlcjnbfFH8zzl/0p189YtENhE6Fyr5bD9MAI6NpVHjLLlg3yjmQ6X95fUtiNCmSpCUveEqIQCRtHCY2E/RrulGqTWE+vCvbM6IJV3WnatPOtWZfXEntWHmS08j6aUkUDM9TodBuzG8TRhW2Kgv8b4pfoejuMa4WkvwRAUU7V+clTWG26dT9UHdk+QuOIQDUiCewWk3PmpIJI4WdcxpBWwDvIgojob7uaGzhkabFKi77RJRc5/Ulxm6yM2MX79jgJxrQprWxxkjlsQnJk186nQZQqpuwziH/ZxV82n1bmI9zCqMXgE1Yr86gvyZpk2UbWhlFdtXEPapge9Cfo/fWUBCIbVcd77Bk98E88Y5Y372YWW+D8oHZed8l+0tCeyZmoHQNCYykcf6w77C+8C+bVdJplPns96vyLgbWIr0cpqZBK4qmkAxHuKZoG0AKRw4U379lnXOsI+02TaTzGOMlFTg4ME5miCbxo/2pUnjrydyTE5evdImLzKAK50Fhy1XASaPxgLrkjhGZebwf1UD2kYg6A1NCHchQId25vSEwGRkMPWvY3a5KOmgsMmRoOUJ17uo/r57p7nLgZV9c1+YEdZxu+GmgwQDLNGpgW1cpEN6GSVpx8xhaGKeYSuqd4lh6H9U5/P8masNckrsz+EHv+w5plzx8nJ/Fx/H50OdOm1KUjo66m26aITX7EjJB/U1qtqNfiK6dt8EttJ5iRXlCbfOkj2biRYeKbXQ2Ezr+61/Mu/W/nhLqmLFDtM6K3xf2bSJnEXQFZOOXTRkKXnRDP7Y47ZgG3563fJQjSfoU4Hsw5xnegTOKlJsoEm95Rnq0esdMTA450Ki2wBOeIsOycljoApACBYLAlSe+ewxEaOjrLtnIR0LfzcKXlCRYbM31YWOCtMhMRehJbX9qWGNPTQHmjabYz7/IhLKtJuaMIpj3pfYgS/oQQ36g6ItCo7vLQAq+rgU99IUyQROOGXMUgK/8umL71oijA9dht0LmH9E7EGwih0WuLO2SndovTJODDfK9YrRTEocbo3B9S05O4fpGoQ32TK99mXjoQdlyxd/dn9Q9uDD27u/fGgUoYdt9VzAIigbRIQuRx430n33V0ZyXv90QuD4ESOLxVI1vnLj6JKAS4PGRz66rouYG6U+1syDWpf5Y6DzC/2KOfdLPwmuwjMQxuhf+6+tGeJbeotNX/eJF0LkRfyieRwEGKxIo0PaxdmVwsF7vKR6ZnOpr5BuLm/+44Rg3bQdJ4bcRW6i6dIhOyHWniLvsAPLu1NZDVN6jA13KTChhcrNnSGddjRFLekawl80E3KhG1p+KvItIZX3kzG4QjJ | ||
CSC_KEY_PASSWORD: | ||
secure: GiXelhGGKXKUNW6T7ptKUw== | ||
CSC_LINK: | ||
secure: 9uSZwUYwcdZejLTpGpySd6t9JSL1Hw3iTvb4T2HZrx6iKd5DSR7AN6A7lS5ThTZ6g1JNSypSHRwDeC1Z5xkP8QEIjDqKjyNrqC19gCiSMrpdjjIR8Y8upIISrDBWjOiI | ||
|
||
platform: | ||
- x64 | ||
|
||
# https://www.appveyor.com/docs/build-cache/ | ||
# hmm, seems there is NPM on windows problem | ||
# with installing over cached folder | ||
# https://github.com/npm/npm/issues/17747 | ||
# cache: | ||
# - node_modules -> yarn.lock | ||
# - '%LOCALAPPDATA%/Yarn -> yarn.lock' | ||
# # todo: cache node_modules in each package | ||
|
||
# Install scripts. (runs after repo cloning) | ||
install: | ||
# it is not a given that AppVeyor has the exact version of Node we need predownloaded | ||
# see https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs | ||
- ps: Update-NodeJsInstallation $env:nodejs_version $env:platform | ||
# - ps: Install-Product node $env:nodejs_version $env:platform | ||
# upgrade npm | ||
- yarn global add @bahmutov/print-env@1 | ||
# Output useful info for debugging. | ||
- node --version | ||
- node --print process.arch | ||
- yarn --version | ||
# prints all public variables relevant to the build | ||
- print-env Platform | ||
- yarn check-node-version | ||
- print-env APPVEYOR | ||
# prints if we have sensitive variables that start with a prefix GH | ||
# which are used to trigger other projects | ||
# ignore errors - forked pull requests will NOT have these variables set | ||
- has-env GH || true | ||
# clean cache to prevent install permission issues | ||
- yarn cache clean | ||
- yarn --frozen-lockfile || yarn --frozen-lockfile || yarn --frozen-lockfile | ||
- yarn build-prod | ||
- .\node_modules\.bin\print-arch | ||
|
||
# Post-install test scripts. | ||
test_script: | ||
# Output useful info for debugging. | ||
# beware of echo-ing environment variables that may have batch syntax (e.g. commit messages) | ||
- node --version | ||
- yarn --version | ||
- 7z | ||
- echo *** System info *** | ||
- node cli/bin/cypress info --dev | ||
|
||
# make sure mocha runs | ||
- yarn test-mocha | ||
# make sure our snapshots are compared correctly | ||
# - npm run test-mocha-snapshot | ||
# the other larger tests | ||
- echo *** Building Windows NPM package *** | ||
- yarn get-next-version --npm | ||
- cd cli | ||
- yarn | ||
- yarn build | ||
- cd build | ||
- yarn pack | ||
- cd ../.. | ||
|
||
- node ./scripts/win-appveyor-build.js | ||
|
||
# Don't actually build. | ||
build: off | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
diff --git a/node_modules/@cypress/code-coverage/support-utils.js b/node_modules/@cypress/code-coverage/support-utils.js | ||
index 31e00ee..0c56908 100644 | ||
--- a/node_modules/@cypress/code-coverage/support-utils.js | ||
+++ b/node_modules/@cypress/code-coverage/support-utils.js | ||
@@ -10,7 +10,7 @@ const filterSpecsFromCoverage = (totalCoverage, config = Cypress.config) => { | ||
const integrationFolder = config('integrationFolder') | ||
/** @type {string} Cypress run-time config has test files string pattern */ | ||
// @ts-ignore | ||
- const testFilePattern = config('testFiles') | ||
+ const testFilePattern = config('specPattern') | ||
|
||
// test files chould be: | ||
// wild card string "**/*.*" (default) | ||
diff --git a/node_modules/@cypress/code-coverage/support.js b/node_modules/@cypress/code-coverage/support.js | ||
index c99ceb2..f51ce4e 100644 | ||
--- a/node_modules/@cypress/code-coverage/support.js | ||
+++ b/node_modules/@cypress/code-coverage/support.js | ||
@@ -37,7 +37,6 @@ const logMessage = (s) => { | ||
* If there are more files loaded from support folder, also removes them | ||
*/ | ||
const filterSupportFilesFromCoverage = (totalCoverage) => { | ||
- const integrationFolder = Cypress.config('integrationFolder') | ||
const supportFile = Cypress.config('supportFile') | ||
|
||
/** @type {string} Cypress run-time config has the support folder string */ | ||
@@ -50,16 +49,9 @@ const filterSupportFilesFromCoverage = (totalCoverage) => { | ||
isSupportFile(filename) | ||
) | ||
|
||
- // check the edge case | ||
- // if we have files from support folder AND the support folder is not same | ||
- // as the integration, or its prefix (this might remove all app source files) | ||
- // then remove all files from the support folder | ||
- if (!integrationFolder.startsWith(supportFolder)) { | ||
- // remove all covered files from support folder | ||
- coverage = Cypress._.omitBy(totalCoverage, (fileCoverage, filename) => | ||
- filename.startsWith(supportFolder) | ||
- ) | ||
- } | ||
+ coverage = Cypress._.omitBy(totalCoverage, (fileCoverage, filename) => | ||
+ filename.startsWith(supportFolder) | ||
+ ) | ||
return coverage | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to record this as an action item to follow up on / add back in one way or another?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm yes probably, we want to make sure all the scaffolded specs still function and work, just without all the complexity of the existing scaffolding setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cypress-io.atlassian.net/browse/UNIFY-657
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cypress-io.atlassian.net/browse/UNIFY-657