Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate module_api to system tests #20265

Merged
merged 10 commits into from
Feb 25, 2022
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Feb 18, 2022

  • Closes

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

Post-merge

  • Archive cypress-test-module-api
  • Archive bumpercar if services doesn't use it
  • Archive make-empty-github-commit

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 18, 2022

Thanks for taking the time to open a PR!

Base automatically changed from docker-binary-system-tests to develop February 18, 2022 23:37
@cypress
Copy link

cypress bot commented Feb 23, 2022



Test summary

19278 0 218 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 483388a
Started Feb 25, 2022 10:30 PM
Ended Feb 25, 2022 10:42 PM
Duration 11:29 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title test: migrate module_api, non_root spec to system tests test: migrate module_api to system tests Feb 25, 2022
@flotwig flotwig marked this pull request as ready for review February 25, 2022 16:36
@flotwig flotwig requested a review from a team as a code owner February 25, 2022 16:36

After the production binary and NPM package are build and uploaded in CI, [`/scripts/test-other-projects.js`](../scripts/test-other-projects.js) is run as part of the `test-other-projects` `circle.yml` step.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

tbiethman
tbiethman previously approved these changes Feb 25, 2022
Co-authored-by: Ryan Manuel <ryanm@cypress.io>
@flotwig flotwig merged commit ffd3627 into develop Feb 25, 2022
@flotwig flotwig deleted the module-api-system-test branch February 25, 2022 23:12
tgriesser added a commit that referenced this pull request Mar 2, 2022
* 10.0-release:
  fix: comment link to accurate docs (#20437)
  fix: scaffold commands file (#20398)
  fix(launchpad): support default export (#20383)
  feat(launchpad): support for Vue CLI 5 (#20413)
  fix: UNIFY-676 browsers should be configurable in setupNodeEvents (#20367)
  fix: make launchpad link open default browser (#20399)
  fix(icons): publish the files in the package
  fix: build icons in build-prod (#20411)
  test: migrate module-api to 10.0
  chore: build this branch
  test: migrate module_api to system tests (#20265)
  chore: remove pkg/driver //@ts-nocheck final (#20169)
  chore: fix "cannot find module" in clone-repo-and-checkout-release-branch (#20293)
  chore: Update Chrome (beta) to 99.0.4844.45 (#20234)
  chore: fix CI cache state for darwin (#20339)
  Add TODO comments
  feedback
  chore: move tests to its own file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants