Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add correct type for preserve cookie callback #20513

Merged
merged 2 commits into from
Apr 1, 2022
Merged

fix(types): add correct type for preserve cookie callback #20513

merged 2 commits into from
Apr 1, 2022

Conversation

jonkoops
Copy link
Contributor

@jonkoops jonkoops commented Mar 7, 2022

User facing changelog

Added the correct type for a cookie for the callback to preserve cookies.

Additional details

This type was set to any, but a correct type Cookie already exists.

@jonkoops jonkoops requested a review from a team as a code owner March 7, 2022 17:50
@jonkoops jonkoops requested review from jennifer-shehane and removed request for a team March 7, 2022 17:50
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 7, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Mar 7, 2022

CLA assistant check
All committers have signed the CLA.

emilyrohrbough
emilyrohrbough previously approved these changes Mar 29, 2022
@jonkoops jonkoops requested a review from a team as a code owner March 30, 2022 15:53
@jonkoops jonkoops requested review from emilyrohrbough and removed request for a team March 30, 2022 15:53
@jonkoops
Copy link
Contributor Author

Did a quick rebase on develop as some random merge commits were added. @emilyrohrbough could you take another look?

@jennifer-shehane jennifer-shehane removed their request for review March 30, 2022 15:56
@lmiller1990 lmiller1990 self-requested a review April 1, 2022 00:29
@lmiller1990 lmiller1990 merged commit 0df0d7a into cypress-io:develop Apr 1, 2022
@jonkoops jonkoops deleted the cookie-preserve-type branch April 1, 2022 09:30
mschile added a commit that referenced this pull request Apr 6, 2022
commit 17e6bf4
Author: Matt Henkes <mjhenkes@gmail.com>
Date:   Wed Apr 6 11:26:03 2022 -0500

    chore: [Multi-domain] Rename switchToDomain to origin (#20927)

    * chore: [Multi-domain] Rename switchToDomain to origin

    * Regenerate system tests snapshots

    * Update cli/schema/cypress.schema.json

    Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

    * Update cli/types/cypress.d.ts

    Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

commit 0772f85
Merge: 81e9283 d0fc93b
Author: mjhenkes <mjhenkes@gmail.com>
Date:   Wed Apr 6 09:51:49 2022 -0500

    Merge branch 'develop' into feature-multidomain

commit d0fc93b
Author: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Date:   Tue Apr 5 17:18:39 2022 -0500

    chore: add internal log group API and update log group styles (#20857)

    Co-authored-by: Matt Henkes <mjhenkes@gmail.com>

commit ee7495f
Author: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
Date:   Tue Apr 5 15:45:12 2022 -0500

    fix: fix flaky report test (#20886)

commit 81e9283
Merge: f45be5e edf9c11
Author: Matt Henkes <mjhenkes@gmail.com>
Date:   Tue Apr 5 11:40:02 2022 -0500

    Merge branch 'develop' into feature-multidomain

commit f45be5e
Author: Matt Henkes <mjhenkes@gmail.com>
Date:   Tue Apr 5 11:39:53 2022 -0500

    chore: [Multi-domain] Resolve flaky test (#20917)

    * chore: [Multi-domain] Resolve flaky test

    * remove ts ignore

    * update comment

    * remove dead code

    * Updated comment

commit edf9c11
Author: Chris Breiding <chrisbreiding@users.noreply.github.com>
Date:   Tue Apr 5 12:07:56 2022 -0400

    fix: Resend *.enable commands on CDP reconnect (#20916)

    Co-authored-by: Zach Bloomquist <git@chary.us>
    Co-authored-by: Matt Henkes <mjhenkes@gmail.com>

commit 0cce18a
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Tue Apr 5 10:04:55 2022 -0500

    chore: Update Chrome (stable) to 100.0.4896.75 (#20909)

    Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com>

commit e0ebd08
Merge: 2e48f85 94fa50d
Author: Blue F <blue@cypress.io>
Date:   Mon Apr 4 14:39:23 2022 -0700

    Merge pull request #20839 from sainthkh/issue-20562

    fix: `cy.type()` + `{enter}` or ` ` should work with Firefox 98+

commit 2e48f85
Author: David Munechika <david.munechika@gatech.edu>
Date:   Mon Apr 4 11:47:02 2022 -0400

    fix: --spec with glob incorrectly splits filename (#20848)

    Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

commit c0d638c
Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Mon Apr 4 06:33:59 2022 +1000

    chore: Update Chrome (beta) to 101.0.4951.15 (#20882)

    Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com>

commit 0df0d7a
Author: Jon Koops <jonkoops@gmail.com>
Date:   Fri Apr 1 03:08:22 2022 +0200

    fix(types): add correct type for preserve cookie callback (#20513)

    Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>

commit 94fa50d
Author: KHeo <sainthkh@naver.com>
Date:   Thu Mar 31 15:03:48 2022 +0900

    feedback

commit c66a23e
Author: KHeo <sainthkh@naver.com>
Date:   Wed Mar 30 16:18:26 2022 +0900

    fix: `cy.type()` should work with Firefox 98+
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 11, 2022

Released in 9.5.4.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.4, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants