fix(types): add correct type for preserve cookie callback #20513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
emilyrohrbough
previously approved these changes
Mar 29, 2022
|
Did a quick rebase on |
ryanthemanuel
approved these changes
Mar 31, 2022
lmiller1990
approved these changes
Apr 1, 2022
mschile
added a commit
that referenced
this pull request
Apr 6, 2022
commit 17e6bf4 Author: Matt Henkes <mjhenkes@gmail.com> Date: Wed Apr 6 11:26:03 2022 -0500 chore: [Multi-domain] Rename switchToDomain to origin (#20927) * chore: [Multi-domain] Rename switchToDomain to origin * Regenerate system tests snapshots * Update cli/schema/cypress.schema.json Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com> * Update cli/types/cypress.d.ts Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com> commit 0772f85 Merge: 81e9283 d0fc93b Author: mjhenkes <mjhenkes@gmail.com> Date: Wed Apr 6 09:51:49 2022 -0500 Merge branch 'develop' into feature-multidomain commit d0fc93b Author: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Date: Tue Apr 5 17:18:39 2022 -0500 chore: add internal log group API and update log group styles (#20857) Co-authored-by: Matt Henkes <mjhenkes@gmail.com> commit ee7495f Author: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Date: Tue Apr 5 15:45:12 2022 -0500 fix: fix flaky report test (#20886) commit 81e9283 Merge: f45be5e edf9c11 Author: Matt Henkes <mjhenkes@gmail.com> Date: Tue Apr 5 11:40:02 2022 -0500 Merge branch 'develop' into feature-multidomain commit f45be5e Author: Matt Henkes <mjhenkes@gmail.com> Date: Tue Apr 5 11:39:53 2022 -0500 chore: [Multi-domain] Resolve flaky test (#20917) * chore: [Multi-domain] Resolve flaky test * remove ts ignore * update comment * remove dead code * Updated comment commit edf9c11 Author: Chris Breiding <chrisbreiding@users.noreply.github.com> Date: Tue Apr 5 12:07:56 2022 -0400 fix: Resend *.enable commands on CDP reconnect (#20916) Co-authored-by: Zach Bloomquist <git@chary.us> Co-authored-by: Matt Henkes <mjhenkes@gmail.com> commit 0cce18a Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Tue Apr 5 10:04:55 2022 -0500 chore: Update Chrome (stable) to 100.0.4896.75 (#20909) Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> commit e0ebd08 Merge: 2e48f85 94fa50d Author: Blue F <blue@cypress.io> Date: Mon Apr 4 14:39:23 2022 -0700 Merge pull request #20839 from sainthkh/issue-20562 fix: `cy.type()` + `{enter}` or ` ` should work with Firefox 98+ commit 2e48f85 Author: David Munechika <david.munechika@gatech.edu> Date: Mon Apr 4 11:47:02 2022 -0400 fix: --spec with glob incorrectly splits filename (#20848) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> commit c0d638c Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Date: Mon Apr 4 06:33:59 2022 +1000 chore: Update Chrome (beta) to 101.0.4951.15 (#20882) Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> commit 0df0d7a Author: Jon Koops <jonkoops@gmail.com> Date: Fri Apr 1 03:08:22 2022 +0200 fix(types): add correct type for preserve cookie callback (#20513) Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> commit 94fa50d Author: KHeo <sainthkh@naver.com> Date: Thu Mar 31 15:03:48 2022 +0900 feedback commit c66a23e Author: KHeo <sainthkh@naver.com> Date: Wed Mar 30 16:18:26 2022 +0900 fix: `cy.type()` should work with Firefox 98+
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Added the correct type for a cookie for the callback to preserve cookies.
Additional details
This type was set to
any, but a correct typeCookiealready exists.