-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver): readFile - verify null contents to Buffer.from #20689
Conversation
…end failed to find file
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Co-authored-by: David Munechika <david.munechika@gatech.edu>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
When
null
encoding is used, and a file cannot be found, we are passingnull
to Buffer.from which is throwingTypeError: First argument must be a string, Buffer, ArrayBuffer, Array, or array-like object
. This caused the command to bail instead of retrying and providing a meaningful error message to the users.User facing changelog
cy.readFile()
where the command would not retry or provide a meaningful error message ifnull
encoding was used and the file was not found. Fixed #20683.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?