Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): readFile - verify null contents to Buffer.from #20689

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

emilyrohrbough
Copy link
Member

User facing changelog

  • Fixed an issue in cy.readFile() where the command would not retry or provide a meaningful error message if null encoding was used and the file was not found. Fixed #20683.

How has the user experience changed?

before after
Screen Shot 2022-03-18 at 9 34 39 AM Screen Shot 2022-03-18 at 9 34 11 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?
  • [n/a] Have new configuration options been added to the cypress.schema.json?

@emilyrohrbough emilyrohrbough requested a review from a team as a code owner March 18, 2022 14:37
@emilyrohrbough emilyrohrbough requested review from jennifer-shehane and removed request for a team March 18, 2022 14:37
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 18, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough requested review from BlueWinds and removed request for jennifer-shehane March 18, 2022 14:37
@cypress
Copy link

cypress bot commented Mar 18, 2022



Test summary

218 0 1 0Flakiness 0


Run details

Project cypress
Status Passed
Commit c6eb90c
Started Mar 18, 2022 6:34 PM
Ended Mar 18, 2022 6:43 PM
Duration 09:20 💡
OS Linux Debian - 10.10
Browser Firefox 93

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

davidmunechika
davidmunechika previously approved these changes Mar 18, 2022
Co-authored-by: David Munechika <david.munechika@gatech.edu>
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 28, 2022

Released in 9.5.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding null as an encoding argument to cy.readFile command results in TypeError
3 participants