Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE #20698

Conversation

amoshydra
Copy link
Contributor

@amoshydra amoshydra commented Mar 19, 2022

User facing changelog

Support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE

Additional details

Related:

To support usage of CYPRESS_DOWNLOAD_PATH_TEMPLATE in npmrc in npm@6

How has the user experience changed?

User will be able to use one of these in npmrc in npm@6

CYPRESS_DOWNLOAD_PATH_TEMPLATE=\${endpoint}/\${platform}-\${arch}/cypress.zip
CYPRESS_DOWNLOAD_PATH_TEMPLATE="\${endpoint}/\${platform}-\${arch}/cypress.zip"

PR Tasks

@amoshydra amoshydra requested a review from a team as a code owner March 19, 2022 03:27
@amoshydra amoshydra requested review from jennifer-shehane and removed request for a team March 19, 2022 03:27
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 19, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2022

CLA assistant check
All committers have signed the CLA.

@amoshydra amoshydra changed the title Support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE feat: support escaped dollar sign in CYPRESS_DOWNLOAD_PATH_TEMPLATE Mar 19, 2022
Copy link
Member

@mjhenkes mjhenkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you for the PR and the detailed investigation!

@mjhenkes mjhenkes merged commit 6915b8e into cypress-io:develop Mar 24, 2022
@amoshydra amoshydra deleted the feat/support-escaped-dollar-sign-in-cypress-download-path-template branch March 27, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistencies in CYPRESS_DOWNLOAD_PATH_TEMPLATE handling
4 participants