Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add alpha/beta labels in launchpad #21111

Merged
merged 7 commits into from
Apr 20, 2022
Merged

feat: add alpha/beta labels in launchpad #21111

merged 7 commits into from
Apr 20, 2022

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Apr 18, 2022 •
edited
Loading

User facing changelog

Add "beta" label for component testing and "alpha" label for Next.js in launchpad.

Additional details

Beta label

image

Alpha label

Note: This screenshot is from a test with mock data, using Create React App as a fixture. It's not really in alpha. You can see in frameworks.ts- see here - which frameworks have the alpha label (just Next.js right now).

image

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 18, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 18, 2022 •
edited
Loading


Test summary

4343 • 0 • 48 • 0 • Flakiness 2

Run details
Project cypress
Status Passed
Commit f32e6c2
Started Apr 20, 2022 5:57 AM
Ended Apr 20, 2022 6:11 AM
Duration 14:08 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️

Flakiness

files.cy.js 1 Flakiness
1 ... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding
net_stubbing.cy.ts 1 Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990 lmiller1990 marked this pull request as ready for review April 18, 2022 03:26
@lmiller1990 lmiller1990 removed the request for review from tgriesser April 18, 2022 03:26
marktnoonan
marktnoonan requested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, I have couple small suggestions on using our existing visually-hidden class to add context to these labels when announced by screen readers.

packages/frontend-shared/src/components/Card.vue Show resolved Hide resolved
packages/launchpad/src/setup/AlphaLabel.vue Show resolved Hide resolved
tbiethman
tbiethman reviewed Apr 18, 2022
View reviewed changes
packages/graphql/src/schemaTypes/objectTypes/gql-WizardFrontendFramework.ts
@@ -31,6 +31,10 @@ export const WizardFrontendFramework = objectType({
description: 'The display name of the framework',
})

t.nonNull.boolean('alpha', {
description: 'Whether the framework is in alpha or not',
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious if it's worth codifying this as supportStatus at this point. Do we anticipate marking future frameworks as "beta" when component testing overall leaves beta?

Copy link
Contributor Author

@lmiller1990 lmiller1990 Apr 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm expecting so - Jess has talked about support for Svelte and is giving a presentation on it soon, and Angular is another one we "support" (inside npm/angular, and part of our "official" adapters) but certainly isn't production ready.

Edit: right, you mean alpha vs beta etc. Good idea, let's do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

tbiethman
tbiethman approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@tbiethman tbiethman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New styles look great 👍

@lmiller1990
Copy link
Contributor Author

Fixed and added requested a11y from Mark.

@lmiller1990 lmiller1990 merged commit d6924ea into 10.0-release Apr 20, 2022
@lmiller1990 lmiller1990 deleted the lmiller1990/UNIFY-1534 branch April 20, 2022 06:39
tgriesser added a commit that referenced this pull request Apr 20, 2022
@tgriesser
Merge branch '10.0-release' into tgriesser/chore/UNIFY-1256-auto-merg…
035bead 
…e-config

* 10.0-release:
  feat: add alpha/beta labels in launchpad (#21111)
  chore: cutting over system-tests and Cypress to use the new CT Object API (#21079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marktnoonan marktnoonan marktnoonan requested changes

@tbiethman tbiethman tbiethman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmiller1990 @tbiethman @marktnoonan