-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle cloud error/no internet error #21526
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…jandro/feat/handle-cloud-errors
…ss-io/cypress into alejandro/feat/handle-cloud-errors
* fix: update gql error handler * Add failing test * Fix test * Update with code review * Update with code review * Update packages/data-context/src/sources/CloudDataSource.ts Co-authored-by: Tim Griesser <tgriesser10@gmail.com> Co-authored-by: Tim Griesser <tgriesser10@gmail.com>
Hey @estrada9166 let me know if I am testing correctly, or maybe something is not in the staging dashboard yet that would support the test?: https://www.loom.com/share/d38c9da77d1940a7aabb422cdea19349 In the video I could not trigger the state in your first screenshot. I was able to add a project after having been removed from the org. I had to log out and log back in to reach this state on the runs page. Until then I saw the regular connect/create project stuff and appeared to still be in the organization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retesting everything today it works fine, not sure what happened yesterday, possibly I was logged in with the wrong credentials at some part? Anyhoo here is a video of it working correctly. If anybody else is looking for steps to test this manually, that video shows what I was doing to test.
Non-blocking suggestion, let's not show this X in the Unauthorized error, since it's not dismissable:
Or we could make it dismissable I guess, to let users clear it and retry and see that the same error has happened.
@estrada9166 Any followup on this PR? |
@jennifer-shehane we should be ready to merge after CI pass! |
* develop: fix: handle cloud error/no internet error (#21526)
* feat: handle cloud error/no internet error * Update error handling * Add tests * Fix TS * Revert change * fix: update gql error handler (cypress-io#21542) * fix: update gql error handler * Add failing test * Fix test * Update with code review * Update with code review * Update packages/data-context/src/sources/CloudDataSource.ts Co-authored-by: Tim Griesser <tgriesser10@gmail.com> Co-authored-by: Tim Griesser <tgriesser10@gmail.com> * Add tests * Prevent showing toaster * Upodate with feedback Co-authored-by: Tim Griesser <tgriesser10@gmail.com> Co-authored-by: Mark Noonan <mark@cypress.io>
User facing changelog
Additional details
Currently, we were not handling some cloud errors - with these changes we now prevent any mutation from org creation/project creation if there's no internet connection; also we are handling the
gql
requests as a global error - this may change to render the mutation errors as an alert inside the component (waiting for some designs updates) - This is a starting point for some more upcoming changesNo access to org
Internal server error
No internet connection
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?