Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timeouts for does not pause timers when disableTimersAn… #21547

Merged
merged 2 commits into from
May 18, 2022

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented May 18, 2022

…dAnimations is false to prevent test race condition

  • Closes N/A

User facing changelog

Additional details

Goal here is to try an reduce flake of the does not pause timers when disableTimersAndAnimations is false test inside the cy.origin suite. It was noticed that sometimes the cy.screenshot onBeforeScreenshot call & subsequent setTimeout were called before the setTimeout before the window.then in a few cases. Simply increasing the timeouts by a few milliseconds should resolve the issue (hopefully).

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

…dAnimations is false to prevent test race condition
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 18, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented May 18, 2022



Test summary

4908 0 64 1Flakiness 0


Run details

Project cypress
Status Passed
Commit 90b3b45
Started May 18, 2022 6:40 PM
Ended May 18, 2022 6:55 PM
Duration 14:55 💡
OS Linux Debian - 10.11
Browser Firefox 98

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AtofStryker AtofStryker marked this pull request as ready for review May 18, 2022 15:17
@AtofStryker AtofStryker requested a review from a team as a code owner May 18, 2022 15:17
@AtofStryker AtofStryker removed the request for review from a team May 18, 2022 15:18
@AtofStryker AtofStryker merged commit 63173a6 into develop May 18, 2022
@AtofStryker AtofStryker deleted the bugfix/fix-snapshot-flake-test branch May 18, 2022 19:50
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2022

Released in 9.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants