Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not ship source for app and launchpad in binary #22033

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Jun 2, 2022

User facing changelog

Do not ship unused source code in app.

Additional details

Make binary slightly smaller by not including the source code for app and launchpad in the binary.

Steps to test

I am on linux.

  1. yarn binary-build
  2. Pick any option for version
  3. Wait for build
  4. ls /tmp/cypress-build/linux/build/linux-unpacked/resources/app/packages/launchpad
  5. Observe we only ship dist - not src
  6. If you want to try it run ./tmp/cypress-build/linux/build/linux-unpacked/Cypress

How has the user experience changed?

It hasn't.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 2, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 2, 2022



Test summary

4874 0 61 0Flakiness 1


Run details

Project cypress
Status Passed
Commit b4a18c4
Started Jun 2, 2022 6:59 PM
Ended Jun 2, 2022 7:13 PM
Duration 13:51 💡
OS Linux Debian - 10.11
Browser Firefox 98

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane jennifer-shehane removed the request for review from emilyrohrbough June 2, 2022 18:58
Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@lmiller1990 lmiller1990 merged commit a264373 into develop Jun 7, 2022
@lmiller1990 lmiller1990 deleted the lmiller1990/do-not-ship-unnecessary-files branch June 7, 2022 00:47
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CT Tests are being bundled & shipped with Cypress binary.
3 participants