Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: warn on sync FS method use in development #22176

Closed
wants to merge 9 commits into from
Closed

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Jun 7, 2022

User facing changelog

Additional details

  • Adds warning when synchronous FS method use is detected.
  • Right now, there are a lot of warnings due to node_modules using sync FS methods.

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 7, 2022

Thanks for taking the time to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on all runtime fs.sync* calls that need to be converted to be async and convert to async
1 participant