-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build Cypress for linux-arm64 #22252
Conversation
@@ -142,7 +142,7 @@ | |||
"dedent": "^0.7.0", | |||
"del": "3.0.0", | |||
"detect-port": "^1.3.0", | |||
"electron": "18.0.4", | |||
"electron": "18.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A regression was introduced in Electron 18 that broke compatibility with Linux Arm, but it's fixed.
cli/.eslintrc.json
Outdated
"message": "Do not use `arch()` to detect the user's machine architecture. Use utils.getRealArch() instead." | ||
}, | ||
{ | ||
"selector": "CallExpression[callee.object.name='process'][callee.property.name='arch']", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also need os.arch
Is this now included in the v10.3.0? |
@borecz Yes, this PR is in Cypress 10.2.0 and above. |
User facing changelog
Additional details
To do
Steps to test
npm i
inside of a Docker for M1 container.How has the user experience changed?
PR Tasks
cypress-documentation
? docs(guides): add darwin/linux arm64 to OS requirements cypress-documentation#4568type definitions
?