feat: build Cypress for linux-arm64 #22252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotwig
commented
Jun 11, 2022
| @@ -142,7 +142,7 @@ | |||
| "dedent": "^0.7.0", | |||
| "del": "3.0.0", | |||
| "detect-port": "^1.3.0", | |||
| "electron": "18.0.4", | |||
| "electron": "18.3.0", | |||
There was a problem hiding this comment.
A regression was introduced in Electron 18 that broke compatibility with Linux Arm, but it's fixed.
tbiethman
requested review from
rockhold and
ryanthemanuel
and removed request for
jennifer-shehane
ryanthemanuel
approved these changes
Jun 13, 2022
flotwig
commented
Jun 13, 2022
cli/.eslintrc.json
Outdated
| "message": "Do not use `arch()` to detect the user's machine architecture. Use utils.getRealArch() instead." | ||
| }, | ||
| { | ||
| "selector": "CallExpression[callee.object.name='process'][callee.property.name='arch']", |
BlueWinds
approved these changes
Jun 14, 2022
BeijiYang
pushed a commit
to BeijiYang/cypress
that referenced
this pull request
Jun 23, 2022
Closed
10 tasks
|
Is this now included in the v10.3.0? |
|
@borecz Yes, this PR is in Cypress 10.2.0 and above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
To do
Steps to test
npm iinside of a Docker for M1 container.How has the user experience changed?
PR Tasks
cypress-documentation? docs(guides): add darwin/linux arm64 to OS requirements cypress-documentation#4568type definitions?