Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpecsList scrolling performance fixes #22256

Conversation

mike-plummer
Copy link
Contributor

  • Fix watcher to prevent Specs Explorer from scrolling back to top when row data is updated
  • Small fixes to reduce likelihood of Latest Runs tooltip from not cleaning up

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

* Debounce virtualized list scroll monitor to avoid interrupting smooth scroll
* Fix 'scroll to top' watcher to only trigger when content of specs list changes rather than reference
* Simplify scroll position reset trigger to just watch search
* Revert changes to virtualized list
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 10, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 10, 2022



Test summary

37553 0 454 0Flakiness 6


Run details

Project cypress
Status Passed
Commit 3c33a6b
Started Jun 10, 2022 10:09 PM
Ended Jun 10, 2022 10:25 PM
Duration 16:11 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
e2e/origin/commands/actions.cy.ts Flakiness
1 cy.origin actions > #consoleProps > .selectFile()
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()
2 cy.origin assertions > #consoleProps > .should() and .and()
This comment includes only the first 5 flaky tests. See all 6 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MuazOthman MuazOthman merged commit 610224d into muaz/CLOUD-577-spec-list-display-latest-runs Jun 11, 2022
@MuazOthman MuazOthman deleted the mikep/COUD-577-specs-list-scroll-fixes branch June 11, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants