Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade windows resource class to large #22258

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

@ryanthemanuel ryanthemanuel commented Jun 11, 2022

User facing changelog

N/A

Additional details

After investigating for #22234 I started wondering whether "large" would be good enough for the resource class on Windows. Circle CI has the UI as:

image

but it appears that behind the scenes there is a difference in the size that allows these builds to succeed more reliably. I'd prefer to have a lower resource class while we're investigating what is necessitating more resources so that we can save money and spot any further issues.

Edit: It appears that this issue is now resolved. If you look at the builds the resource class is reflected properly.

Steps to test

Check Circle to ensure that the build passes

How has the user experience changed?

N/A

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 11, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 11, 2022



Test summary

4921 0 61 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 7a7cae1
Started Jun 11, 2022 3:49 PM
Ended Jun 11, 2022 4:05 PM
Duration 16:04 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()
next.cy.ts Flakiness
1 Working with next-12.1.6 > should live-reload on src changes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ryanthemanuel ryanthemanuel merged commit 9505edd into develop Jun 13, 2022
@ryanthemanuel ryanthemanuel deleted the ryanm/playground/change-to-large branch June 13, 2022 14:29
BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants