feat: Column width updates for latest runs and average duration work #22269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
pstakoun
commented
Jun 12, 2022
packages/app/src/specs/SpecsList.vue
Outdated
| data-cy="specs-testing-type-header" | ||
| > | ||
| {{ props.gql.currentProject?.currentTestingType === 'component' ? | ||
| t('specPage.componentSpecsHeader') : t('specPage.e2eSpecsHeader') }} | ||
| </div> | ||
| <div class="flex col-span-2 items-center justify-between"> | ||
| <div class="flex items-center justify-between whitespace-nowrap"> |
There was a problem hiding this comment.
not sure if there is a better way to do this - this was the only header that was wrapping on smaller screens
pstakoun
commented
Jun 12, 2022
pstakoun
changed the title
MuazOthman
reviewed
Jun 13, 2022
Co-authored-by: Muaz Othman <muazweb@gmail.com>
3 tasks
…-latest-runs' into peter/feat/aci-columns
MuazOthman
approved these changes
Jun 14, 2022
mike-plummer
approved these changes
Jun 14, 2022
|
@pstakoun Could you please fill out the PR template explaining the work in this PR? |
tbiethman
reviewed
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Changes the Spec Explorer column sizes and adds padding to the rightmost column for Dashboard Integration data so the data is not flush with the scrollbar.
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?