Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes for App/Cloud GraphQL issues #22288

Conversation

tgriesser
Copy link
Member

@tgriesser tgriesser commented Jun 13, 2022

  • Fixes missing variables in remotely stitched GraphQL requests
  • Adds missing ExternalLink components causing Vue warnings
  • Fixes for pagination

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 13, 2022

Thanks for taking the time to open a PR!

@tgriesser tgriesser changed the title Fixes for App/Cloud GraphQL issues fix: Fixes for App/Cloud GraphQL issues Jun 13, 2022
@cypress
Copy link

cypress bot commented Jun 13, 2022



Test summary

37553 0 454 0Flakiness 5


Run details

Project cypress
Status Passed
Commit 22047ee
Started Jun 13, 2022 4:16 PM
Ended Jun 13, 2022 4:33 PM
Duration 16:54 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
2 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
commands/xhr.cy.js Flakiness
1 ... > logs response
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@MuazOthman MuazOthman self-requested a review June 13, 2022 20:01
@MuazOthman MuazOthman marked this pull request as ready for review June 13, 2022 20:36
@MuazOthman MuazOthman merged commit 4e4e461 into muaz/CLOUD-577-spec-list-display-latest-runs Jun 13, 2022
@MuazOthman MuazOthman deleted the tgriesser/fix/gql-issues branch June 13, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants