Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unused system-test project #22289

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

ZachJW34
Copy link
Contributor

User facing changelog

na

Additional details

The project I removed is unused and does not contain a yarn.lock, causing yarn workspace @tooling/system-tests projects:yarn:install to fail locally. I believe this is being masked by the circleci cache, but it is causing my PR against master to fail.

Steps to test

Run yarn workspace @tooling/system-tests projects:yarn:install locally. Without the changes from my PR, this will fail

How has the user experience changed?

na

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@ZachJW34 ZachJW34 requested review from a team as code owners June 13, 2022 16:23
@ZachJW34 ZachJW34 requested review from jennifer-shehane and removed request for a team June 13, 2022 16:23
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 13, 2022

Thanks for taking the time to open a PR!

@flotwig
Copy link
Contributor

flotwig commented Jun 13, 2022

How did this even make it to develop, I wonder? Maybe we need a step outside of the cache step that validates projects with pkg.json also have a lockfile

@ZachJW34
Copy link
Contributor Author

ZachJW34 commented Jun 13, 2022

@flotwig yeah an extra step makes sense. This PR introduced it, not sure why their was a cache hit but not sure exactly how the caching works.

@ZachJW34
Copy link
Contributor Author

@flotwig created a followup issue #22290

@ZachJW34 ZachJW34 merged commit 36d82f9 into develop Jun 13, 2022
@ZachJW34 ZachJW34 deleted the zachw/fix-system-tests-node-install branch June 13, 2022 17:03
@cypress
Copy link

cypress bot commented Jun 13, 2022



Test summary

4876 0 59 0Flakiness 0


Run details

Project cypress
Status Passed
Commit b7868b7
Started Jun 13, 2022 4:50 PM
Ended Jun 13, 2022 5:05 PM
Duration 15:12 💡
OS Linux Debian - 10.11
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

BeijiYang pushed a commit to BeijiYang/cypress that referenced this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants