Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add component tests for ACI latest specs #22318

Conversation

mike-plummer
Copy link
Contributor

  • Adding component tests to cover new components and behaviors (more to come)
  • Fix small issue disguising graphql resolver issues during component tests
  • Styling fix for ACI latest runs tooltip so it points to the latest run dot

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 14, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 14, 2022



Test summary

37553 0 454 0Flakiness 3


Run details

Project cypress
Status Passed
Commit 6755fd2
Started Jun 15, 2022 1:28 PM
Ended Jun 15, 2022 1:45 PM
Duration 17:10 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

next.cy.ts Flakiness
1 Working with next-12 > should detect new spec
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
2 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@MuazOthman MuazOthman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice organization and coverage!
Left some minor comments.

packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecListGitInfo.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
packages/app/src/specs/SpecRunSummary.cy.tsx Outdated Show resolved Hide resolved
* Add ResultCounts test for string values
* Fix comments
* Add TS typing
@mike-plummer mike-plummer merged commit 52d738f into muaz/CLOUD-577-spec-list-display-latest-runs Jun 15, 2022
@mike-plummer mike-plummer deleted the mikep/CLOUD-577-component-tests branch June 15, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants