Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try Vite 3 pre-release #22748

Closed
wants to merge 5 commits into from
Closed

chore: try Vite 3 pre-release #22748

wants to merge 5 commits into from

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Jul 12, 2022

  • Closes N/A

User facing changelog

N/A

Additional details

Vite 3 is out. We should support it.

I found at least one blocker for us, I logged a Vite issue about it: vitejs/vite#9059

  • has recommended fix/work around, see the issue

Resources

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 12, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 12, 2022



Test summary

37712 5 456 0Flakiness 10


Run details

Project cypress
Status Failed
Commit 7f57405
Started Jul 12, 2022 5:57 AM
Ended Jul 12, 2022 6:26 AM
Duration 29:19 💡
OS Linux Debian - 10.11
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: 5x-driver-firefox (Linux, Firefox )
commands/net_stubbing.cy.ts Failed
1 ... > reconcile changes > throwing errors correctly > setPrototypeOf
Run group: vite-dev-server (Linux, Chrome )
react.cy.ts Failed
1 Working with vite-3-react > should mount a passing test
2 Working with vite-3-react > MissingReact: should fail, rerun, succeed
3 Working with vite-3-react > MissingReactInSpec: should fail, rerun, succeed
4 Working with vite-3-react > AppCompilationError: should fail with uncaught exception error

Flakiness

actions/click.cy.js Flakiness
1 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
2 ... > scroll-behavior > can scroll to and click elements in html with scroll-behavior: smooth
xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor Author

Got this error for Vite 3 w/ React

image

Not sure why, I guess some breaking change. Let's find out.

@lmiller1990 lmiller1990 changed the title chore: add a test for vite 3 pre-release chore: try Vite 3 pre-release Jul 13, 2022
@lmiller1990 lmiller1990 deleted the lmiller/vite-3 branch July 29, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant