Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: only collect logs when reporter should show logs #23729

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

emilyrohrbough
Copy link
Member

@emilyrohrbough emilyrohrbough commented Sep 8, 2022

Apart of #23391
Apart of #21135

When CYPRESS_NO_COMMAND_LOG=1 is passed to hide the reporter's command log, we do not need to track each log in memory because the user cannot interact with it.

User facing changelog

n/a - don't believe this is not worthy

PR Tasks

  • [n/a] Have tests been added/updated?
  • [n/a] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 8, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Sep 8, 2022



Test summary

40010 0 3346 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 7612e9c
Started Sep 8, 2022 5:15 PM
Ended Sep 8, 2022 5:30 PM
Duration 15:02 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/location.cy.ts Flakiness
1 cy.origin location > .hash()
2 cy.origin location > #consoleProps > .location()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@emilyrohrbough emilyrohrbough merged commit 8552e50 into develop Sep 8, 2022
@emilyrohrbough emilyrohrbough deleted the only-collect-logs-when-reporter-should-show branch September 8, 2022 20:12
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Sep 13, 2022

Released in 10.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants