Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new login and "connect project" logic #23762
feat: implement new login and "connect project" logic #23762
Changes from 162 commits
7276fd9
10c31f0
6988e9e
939faab
8cbeca0
809dd3d
58e4ccd
5bdb629
2ae7e0d
8cc921b
2f201f8
6bd7381
3aa9da2
0a37597
6048a94
b6fa50f
03b082c
0411b0d
ee37e2c
ede11eb
e476d8d
ff63834
4fa6aaa
5183162
34c8265
4b7e2f6
62f9194
f0f7b74
530007e
fa3b4c6
1818717
7996152
6c12345
941a7fe
8bba896
df8d609
1f80232
475a251
d298b9e
1d6393d
4082b0f
6b96271
040031a
5a9de4b
24f8a24
493c433
24f99c6
d221055
d94df20
ac5fc6d
e6b5d6a
19cc7d5
e9329b6
8e89aa6
57bc7fb
215d237
5e5cca3
f51a9d8
1644231
0a3a760
f3d5b7a
ce1c85e
4f4e778
7b16441
8a82f12
1c33a43
9e67eba
3ceba41
1d6d556
a73d165
a69fcde
efc47b4
95a6c67
785fe4e
570b651
b3e7092
208e4c1
a4747b8
ebb2792
771df0e
cb166fd
c91b8cb
0552d2c
384e02f
1cea77f
03e0b1a
c20c567
9ea344c
561a648
d7ce339
350ea02
9bb42a5
26f7a9f
ecd8089
5d7f0eb
9fca485
9672175
0977a0c
9461d13
cfb56d1
017579a
19423e3
9495978
35b984e
748de6b
23efaa8
7ae01c2
79e9c17
91b8db0
c3fd39b
580bccd
0dff819
85f08ae
6591fa7
2ec8649
9c39fca
497a45f
f6f3cbe
20ecb39
301cdf2
b2e5989
6b07a36
d15f9ed
0e7f2db
e10f0e0
5e517ad
8e092fd
0b66d17
6e66b48
5db96e0
630fe55
8c68329
4bc3cd8
1e8668f
609a439
83f09cc
bcb54e0
92c2a78
84b0ef1
e315b20
cf24ac1
fca93b3
4f871aa
51a1a89
3b71016
e444839
d7b3444
865b465
b59d4d7
5187785
756ca36
040020f
22f99b4
cb20aff
d8b8400
4b1cdd7
aec9c69
996780d
c1d2972
a9b4bd4
b1e86df
a86207d
0bcd57f
240bffa
a599509
8743552
8459c72
df66e9c
8670967
4f1b2c2
b24e81f
2e3b5a0
03a0c3c
ca789db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that the need for
firstOrganization
was introduced in previous work, but I hope we can take some more time soon to find out why we have to rely on this trick while we also have theorganizations
being returned at the same time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was just updating existing code, but looking at the rest of the code base, this spec file is the only place that there is conditional logic based on
operationName
. This is a fragile pattern to have look at this string. This is definitely a code smell to me but I have not looked at what the alternative would be yet.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mutation names do get into a lot of places, and since their naming convention depends on our component architecture, we end up expressing that architecture in our tests, which yeah does feel a bit off, but also not a huge burden in practice imo, since we rarely change the architecture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then changes in these intercepts let them behave correctly now that more than just the
Runs
component is using them - don't need a strict match on full operation nameThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was flaky for me, some minor changes in this file to address that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Standardize on
frontend-shared
import? We wither use@packages/frontend-shared
or relative import or@cy/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I can standardize the ones in this PR at least, we are pretty inconsistent.