Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(session): require setup function to use session command #24312

Merged
merged 7 commits into from Oct 25, 2022

Conversation

emilyrohrbough
Copy link
Member

Nothing in our docs indicates that setup is optional and by allowing it to be optional diverages from the concept of each test should be able to run independently from one-another because the session had to be been creates at least once to omit the setup function without an error.

Note: This is a breaking change in the experimental API.

User facing changelog

The cy.session() command now requires a setup command to use the command. Addresses #24311.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 19, 2022

Thanks for taking the time to open a PR!

@emilyrohrbough emilyrohrbough added the topic: session Issues when using session command label Oct 19, 2022
@emilyrohrbough emilyrohrbough self-assigned this Oct 19, 2022
@cypress
Copy link

cypress bot commented Oct 19, 2022



Test summary

192 0 26 0Flakiness 2


Run details

Project cypress
Status Passed
Commit e7fbe0d
Started Oct 25, 2022 2:22 PM
Ended Oct 25, 2022 2:32 PM
Duration 09:55 💡
OS Linux Debian - 11.4
Browser Chrome 106

View run in Cypress Dashboard ➡️


Flakiness

scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > vuecli5vue3 > scaffolds component testing for Vue CLI 5 w/ Vue 3 project
global-mode.cy.ts Flakiness
1 Launchpad: Global Mode > when projects have been added > updates most-recently opened project list when returning from next step

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mjhenkes mjhenkes self-requested a review October 25, 2022 14:55
@emilyrohrbough emilyrohrbough merged commit 928315d into develop Oct 25, 2022
@emilyrohrbough emilyrohrbough deleted the make-setup-required branch October 25, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: session Issues when using session command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make session setup function required
3 participants