New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vue2 global directives in component testing #24488
Merged
lmiller1990
merged 6 commits into
cypress-io:develop
from
crazyk2:fix-vue2-global-directives
Nov 14, 2022
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4245cf4
fix vue2 global directives in component testing
crazyk2 7e34a54
fix vue2 global directives in component testing
crazyk2 06f275b
update test
lmiller1990 1cf94aa
Merge branch 'develop' into fix-vue2-global-directives
ZachJW34 a28d808
Merge branch 'develop' into fix-vue2-global-directives
ZachJW34 51f264b
comment out flaky spec [skip ci]
lmiller1990 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# vueclivue2-unconfigured | ||
# vueclivue2-configured | ||
|
||
## Project setup | ||
``` | ||
|
9 changes: 9 additions & 0 deletions
9
...ests/projects/vueclivue2-configured/src/components/GlobalComponentWithCustomDirective.vue
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<template> | ||
<div class="child" v-custom="test" /> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
name: 'GlobalComponentWithCustomDirective', | ||
} | ||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
export default { | ||
name: 'custom', | ||
bind (el, binding) { | ||
el.dataset['custom'] = binding.value | ||
}, | ||
unbind (el) { | ||
el.removeAttribute('data-custom') | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,14 @@ | ||
import Vue from 'vue' | ||
import App from './App.vue' | ||
import GlobalComponentWithCustomDirective from './components/GlobalComponentWithCustomDirective.vue' | ||
import custom from './directive' | ||
|
||
Vue.config.productionTip = false | ||
Vue.component('GlobalComponentWithCustomDirective', GlobalComponentWithCustomDirective) | ||
Vue.directive('custom', custom) | ||
|
||
new Vue({ | ||
render: function (h) { return h(App) }, | ||
render (h) { | ||
return h(App) | ||
}, | ||
}).$mount('#app') |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job figuring out where to add a test 👍