Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use updated kitchen sink #25006

Merged
merged 5 commits into from Dec 6, 2022
Merged

Conversation

mjhenkes
Copy link
Member

@mjhenkes mjhenkes commented Dec 6, 2022

  • Closes

User facing changelog

  • Fixed issue where tests using a removed api were scaffolded into new projects.

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 6, 2022



Test summary

24850 0 2489 0Flakiness 23


Run details

Project cypress
Status Passed
Commit 1a1b4f8
Started Dec 6, 2022 8:51 PM
Ended Dec 6, 2022 9:08 PM
Duration 16:55 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
3 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
4 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
5 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 23 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mjhenkes mjhenkes merged commit afb66ab into develop Dec 6, 2022
@mjhenkes mjhenkes deleted the matth/fix/use-updated-examples branch December 6, 2022 21:44
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 7, 2022

Released in 12.0.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.0.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants