Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add messaging for retention state exceeded #25361

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

mike-plummer
Copy link
Contributor

@mike-plummer mike-plummer commented Jan 4, 2023

User facing changelog

No changelog entry, merging to feature branch

Additional details

Adding handling for new "Data Retention" messaging state when an OVERLIMIT is reported. Extending messaging for "usage" overlimits by adding test recording limit value to message.

See #25352 for details

Steps to test

See DebugRunStates.cy.tsx for new states, Percy snapshots generated for all four permutations (Retention User, Retention Admin, Usage User, Usage Admin)

How has the user experience changed?

State Screenshot
Usage - User Screen Shot 2023-01-04 at 1 35 54 PM
Usage - Admin Screen Shot 2023-01-04 at 1 36 01 PM
Retention - User Screen Shot 2023-01-04 at 1 36 09 PM
Retention - Admin Screen Shot 2023-01-04 at 1 36 17 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@mike-plummer mike-plummer marked this pull request as ready for review January 4, 2023 20:22
@cypress
Copy link

cypress bot commented Jan 4, 2023

@mike-plummer mike-plummer requested a review from a team January 4, 2023 20:56
Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Only two minor updates.

packages/app/src/debug/DebugPageDetails.vue Outdated Show resolved Hide resolved
packages/app/src/debug/DebugPageDetails.vue Outdated Show resolved Hide resolved
@warrensplayer warrensplayer requested a review from a team January 5, 2023 02:04
Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, going to approve assuming that @warrensplayer comment on the isHidden will be addressed.

packages/app/src/debug/DebugOverLimit.vue Outdated Show resolved Hide resolved
packages/app/src/debug/DebugOverLimit.vue Outdated Show resolved Hide resolved
packages/app/src/debug/DebugPageDetails.vue Outdated Show resolved Hide resolved
packages/app/src/debug/DebugOverLimit.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mike-plummer mike-plummer merged commit 19f76b3 into feature/IATR-M0 Jan 5, 2023
@mike-plummer mike-plummer deleted the mikep/25352-overlimit-msgs branch January 5, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants