Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only render debug artifacts when info is available #25362

Merged
merged 6 commits into from
Jan 6, 2023

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Jan 4, 2023

User facing changelog

n/a - Feature branch

Additional details

Only render debug artifacts if the corresponding has<attr> is true and the <attr>Url is defined.

Steps to test

  1. Check out this branch and the cypress-services feature branch, make sure the cypress-services dev is running
  2. Create a project if you don't have one
  3. Choose a repo with Cypress setup and a simple test that will fail
  4. Add video: false to the cypress config
  5. Run CYPRESS_INTERNAL_ENV=development npx cypress run --record --key <RECORD_KEY>
  6. Edit DebugContainer.vue and change runByNumber(runNumber: <RUN_NUMBER>), the last step should have recorded a run to your locally running dashboard and you can find the run number there

You can disable screenshots if you like and record another run.

How has the user experience changed?

Screen.Recording.2023-01-04.at.2.32.51.PM.mov

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

packages/app/src/debug/DebugFailedTest.cy.tsx Outdated Show resolved Hide resolved
packages/app/vite-env.d.ts Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Jan 4, 2023



Test summary

658 1 29 0Flakiness 4


Run details

Project cypress
Status Failed
Commit 5e2099e
Started Jan 6, 2023 3:33 PM
Ended Jan 6, 2023 3:46 PM
Duration 12:48 💡
OS Linux Debian -
Browser Chrome 106

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/migration.cy.ts Failed
1 global mode > migrates 2 projects in global mode

Flakiness

cypress-in-cypress-run-mode.cy.ts Flakiness
1 Cypress In Cypress - run mode > e2e run mode spec runner header is correct
specs_list_latest_runs.cy.ts Flakiness
1 App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs
cypress-in-cypress-component.cy.ts Flakiness
1 Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found
cypress-origin-communicator.cy.ts Flakiness
1 Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@@ -52,7 +52,7 @@

<script setup lang="ts">
import { gql } from '@urql/vue'
import { computed } from '@vue/reactivity'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this in a few files, thought I'd fix them all

Copy link
Contributor

@warrensplayer warrensplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Just added one suggestion.

packages/app/src/debug/DebugFailedTest.cy.tsx Outdated Show resolved Hide resolved
@ZachJW34
Copy link
Contributor Author

ZachJW34 commented Jan 6, 2023

Going to merge, CI failed due to a flaky test and I've created an issue + PR for skipping it: #25378

@ZachJW34 ZachJW34 merged commit 9e2bf5b into feature/IATR-M0 Jan 6, 2023
@ZachJW34 ZachJW34 deleted the zachw/debug-artifacts-fix branch January 6, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants