feat: scan for 3rd party ct plugins #25749

ZachJW34 · 2023-02-08T21:03:56Z

WIP

Closes Define API for third party CT in Launchpad #25680

Additional details

Steps to test

Clone the cypress-ct-solidjs
Run yarn && yarn cypress:open within cypress and point it at the cloned repo. The dep should be detected when setting up CT Testing.

How has the user experience changed?

Screen.Recording.2023-02-08.at.3.02.44.PM.mov

PR Tasks

Have tests been added/updated?
Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

…api-refactor

…ler/ct-public-api-refactor

lmiller1990

Some tentative comments/feedback

lmiller1990 · 2023-02-09T20:55:55Z

packages/data-context/src/actions/WizardActions.ts

+
+  private async detectFrameworks (projectRoot: string) {
+    const officialFrameworks = CT_FRAMEWORKS.map((framework) => resolveComponentFrameworkDefinition(framework))
+    const thirdPartyFrameworks = await detectThirdPartyCTFrameworks(projectRoot).then((frameworks) => frameworks.map(resolveComponentFrameworkDefinition))


Should we just use await (await ...? Any reason do .then?

Also, I think we only need to detect third party frameworks if component testing is NOT configured. That would save a lot of work - they are only needed if CT has not been configured.

I just thought it looked nicer, one less variable declaration. I use this pattern a bit and it's simply a code styling preference.

lmiller1990 · 2023-02-09T20:57:06Z

packages/data-context/src/data/coreDataShape.ts

@@ -199,7 +199,7 @@ export function makeCoreData (modeOptions: Partial<AllModeOptions> = {}): CoreDa
      detectedBundler: null,
      detectedFramework: null,
      // TODO: API to add third party frameworks to this list.
-      frameworks: CT_FRAMEWORKS.map((framework) => resolveComponentFrameworkDefinition(framework)),
+      frameworks: [],


Yeah was wondering about the best place to do this. I wonder if we should only trigger this when they click on "Configure CT"? That's the latest possible "trigger" to load them.

lmiller1990 · 2023-02-09T20:58:08Z

packages/launchpad/cypress/e2e/scaffold-component-testing.cy.ts

+
+      cy.contains('li', '@builder.io/qwik').within(() => {
+        cy.findByLabelText('installed')
+      })


Oh nice, I guess quik exposes package.json?

We may need a fallback for projects that do not, but we can add this as a fast follow

Yeah Qwik was the one I found that had it setup properly. The framework detection works fine, it's just for version detection that it's busted if they don't export package.json

lmiller1990 · 2023-02-09T20:58:42Z

packages/launchpad/src/setup/EnvironmentSetup.vue

@@ -104,6 +106,7 @@ const frameworks = computed(() => {
      name: x.name,
      id: x.id,
      isDetected: x.isDetected,
+      icon: x.icon || undefined,


It'd be nice to have a fallback, but I don't really want to involve design at this late stage. It doesn't look too weird with a blank space, does it?

No it's not too bad, and I think it's ok to assume that a developer will configure their definition correctly

lmiller1990 · 2023-02-09T20:59:25Z

packages/scaffold-config/package.json

@@ -17,7 +17,8 @@
    "compare-versions": "4.1.3",
    "debug": "^4.3.4",
    "fs-extra": "^9.1.0",
-    "globby": "^11.0.1"
+    "globby": "^11.0.1",
+    "zod": "^3.20.3"


Been wanting to try zod, do we know how much this adds to the size of the binary?

https://bundlephobia.com/package/zod@3.20.5 no external deps so it's pretty light. I've been wanting to use it as well, seemed like a perfect place.

lmiller1990 · 2023-02-09T21:01:05Z

packages/scaffold-config/src/ct-detect-third-party.ts

+  componentIndexHtml: z.optional(z.function()),
+})
+
+const CT_FRAMEWORK_GLOB = 'node_modules/cypress-ct-*/package.json'


Do we need something special for windows? Iirc some weirdness with globby and slashes?

Good point I'll check

lmiller1990 · 2023-02-09T21:02:13Z

packages/scaffold-config/src/ct-detect-third-party.ts

+
+          debug('Attempting to resolve third party module with require.resolve: %s', packageRoot)
+
+          const modulePath = require.resolve(packageRoot)


Yeah, we need to sort this out.

lmiller1990 · 2023-02-09T21:03:22Z

packages/scaffold-config/src/ct-detect-third-party.ts

+        } catch (e) {
+          debug('Failed to parse third party module with validation error: %o', e)
+
+          return false


@astone123 makes a good point here https://cypressio.slack.com/archives/C03HVHJU1BR/p1675969606409539

We may need a warning message in the UI to support "no dead ends". WDYT? It would be useful for development. Something like

"Tried to load cypress-ct-qwik but the schema validation failed: ".

I think this will need to bubble up and get caught in data-context and dispatch with packages/errors

lmiller1990 · 2023-02-09T21:03:58Z

packages/scaffold-config/src/ct-detect-third-party.ts

+  } catch (e) {
+    debug('Error occurred while looking for 3rd party CT plugins: %o', e)
+
+    return []


If 1 fails and 1 doesn't, shoudl we just return the valid one? It looks like right now this is all or nothing.

If an error bubbles up here it would be due to a problem with file globbing, the imports all have their own special handling so as to allow filtering out the bad eggs

ZachJW34 · 2023-02-09T21:52:45Z

system-tests/projects/qwik-app/.gitignore

@@ -0,0 +1,38 @@
+# Build


Remove this file.

ZachJW34 · 2023-02-09T21:53:15Z

system-tests/projects/qwik-app/cypress-ct-qwik/index.js

+
+  mountModule: (projectPath) => Promise.resolve('cypress-ct-qwik'),
+
+  icon: '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 166 155.3"><defs><linearGradient id="a" gradientUnits="userSpaceOnUse" x1="27.5" y1="3" x2="152" y2="63.5"><stop offset=".1" stop-color="#76b3e1"/><stop offset=".3" stop-color="#dcf2fd"/><stop offset="1" stop-color="#76b3e1"/></linearGradient><linearGradient id="b" gradientUnits="userSpaceOnUse" x1="95.8" y1="32.6" x2="74" y2="105.2"><stop offset="0" stop-color="#76b3e1"/><stop offset=".5" stop-color="#4377bb"/><stop offset="1" stop-color="#1f3b77"/></linearGradient><linearGradient id="c" gradientUnits="userSpaceOnUse" x1="18.4" y1="64.2" x2="144.3" y2="149.8"><stop offset="0" stop-color="#315aa9"/><stop offset=".5" stop-color="#518ac8"/><stop offset="1" stop-color="#315aa9"/></linearGradient><linearGradient id="d" gradientUnits="userSpaceOnUse" x1="75.2" y1="74.5" x2="24.4" y2="260.8"><stop offset="0" stop-color="#4377bb"/><stop offset=".5" stop-color="#1a336b"/><stop offset="1" stop-color="#1a336b"/></linearGradient></defs><path d="M163 35S110-4 69 5l-3 1c-6 2-11 5-14 9l-2 3-15 26 26 5c11 7 25 10 38 7l46 9 18-30z" fill="#76b3e1"/><path d="M163 35S110-4 69 5l-3 1c-6 2-11 5-14 9l-2 3-15 26 26 5c11 7 25 10 38 7l46 9 18-30z" opacity=".3" fill="url(#a)"/><path d="M52 35l-4 1c-17 5-22 21-13 35 10 13 31 20 48 15l62-21S92 26 52 35z" fill="#518ac8"/><path d="M52 35l-4 1c-17 5-22 21-13 35 10 13 31 20 48 15l62-21S92 26 52 35z" opacity=".3" fill="url(#b)"/><path d="M134 80a45 45 0 00-48-15L24 85 4 120l112 19 20-36c4-7 3-15-2-23z" fill="url(#c)"/><path d="M114 115a45 45 0 00-48-15L4 120s53 40 94 30l3-1c17-5 23-21 13-34z" fill="url(#d)"/></svg>',


This is a solid icon 😅

lmiller1990 · 2023-02-09T22:15:17Z

packages/scaffold-config/src/ct-detect-third-party.ts

+  supportedBundlers: z.array(BundlerSchema),
+  detectors: DependencyArraySchema,
+  dependencies: z.function(),
+  mountModule: z.function(),


Just use string as discussed

lmiller1990

Looks good to me, probably a few quick tweaks, I'll do those on the main feature branch.

…lugins

* chore: rework component onboarding in launchpad (#25713) * chore: refactoring and types * rework source of frameworks * revert rename * fix tests * fix more tests * types * update code * use same public API internally * rename interfaces * rename * work on dev server api * fix types * fix test * attempt to support getDevServerConfig * tests * add function to define framework [skip ci] * rework a lot of types * fix test * update tests and types * refactor * revert changes * lint * fix test * revert * remove * add "community" label [skip ci] * refactor * types * lint * fix bug * update function name * address feedback * improve types with Pick * refactor using type guard * correct label --------- Co-authored-by: Zachary Williams <ZachJW34@gmail.com> * chore: typing error * feat: scan for 3rd party ct plugins (#25749) * chore: refactoring and types * rework source of frameworks * revert rename * fix tests * fix more tests * types * update code * use same public API internally * rename interfaces * rename * work on dev server api * fix types * fix test * attempt to support getDevServerConfig * tests * add function to define framework [skip ci] * rework a lot of types * fix test * update tests and types * refactor * revert changes * lint * fix test * revert * remove * add "community" label [skip ci] * refactor * types * lint * fix bug * update function name * address feedback * feat: scan for 3rd party ct plugins * add e2e test * unit tests [run ci] * tweak resolution * rebase, address comments * fix windows paths * remove .gitignore * fix test --------- Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * lint config * spacing * try fix race cond * fix import error * build binary * try update snapshot * try using require * support namespaced definitions (#25804) * remove category * add icon prop * support esm -> cjs compiled typescript * fix test * misc: add CTA footer to launchpad framework dropdown (#25831) * remove test project dependencies * rebase * windows * windows again * add changelog entry * changelog * revert workflow * remove worklfow --------- Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Adam Stone-Lord <adams@cypress.io>

* fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730) * chore: debug page tooltip distance and artifact border (#25727) * misc: debug page tooltip distance and artifact border * add changelog entry * fix CT test * fix: Improve error handling around calls to `this.next` in middleware (#25702) * chore: update changelog validation example (#25742) * misc: improve debug loading text wrap responsiveness (#25703) * misc: Increase max failures in IATR badge to 99 (#25737) * chore: exclude collaborator issues/PRs from triage project (#25769) * feat: add --auto-cancel-after-failures flag (#25237) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Matt Schile <mschile@cypress.io> Co-authored-by: Ryan Pei <ryanppei@gmail.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com> * chore: Update v8 snapshot cache (#25592) * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * Update update_v8_snapshot_cache.yml * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache --------- Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: cypress-bot[bot] <47117332+cypress-bot[bot]@users.noreply.github.com> * fix: implement new graphql fields for spec counts (#25757) Co-authored-by: Stokes Player <stokes@cypress.io> Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com> * feat: Bundle cy.origin() dependencies at runtime (#25626) Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <ryanm@cypress.io> * chore: remove zenhub from release process (#25701) Co-authored-by: Matt Schile <mschile@cypress.io> * feat: add Cypress.Commands.overwriteQuery (#25674) * feat: add Cypress.Commands.overwriteQuery Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Zach Bloomquist <git@chary.us> * fix: spawn child process with process.env in macOS arm64 (#25753) Co-authored-by: Matt Schile <mschile@cypress.io> Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Zach Bloomquist <github@chary.us> * chore: lint system tests in CI (#25673) * fix: Suppress filesystem errors during glob search (#25774) * chore: issue with ts-loader missing in binary and problematic esbuild norewrite construct (#25797) * chore: update changelog linting (#25809) * docs(guides): add more detail to code-signing (#25794) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * chore: update workflows.yml to include the v8 snapshot update branch (#25784) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: internal request preflight (#25772) --------- Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: Matt Henkes <mjhenkes@gmail.com> Co-authored-by: Zach Bloomquist <git@chary.us> * chore: bump for 12.6.0 release (#25812) * chore: release @cypress/webpack-batteries-included-preprocessor-v2.4.0 [skip ci] * chore: release @cypress/webpack-preprocessor-v5.17.0 [skip ci] * test: skip flaky GitDataSource test (#25825) * chore: making our add-to-triage-board workflow reusable within the Cypress-io org (#25820) * chore: Making our add to triage workflow callable from other projects inside the Cypress-io org in Github * chore: updated cypress-example-kitchensink version (#25828) * fix: duplicate and expired cookies (#25761) * chore: add regression tests for duplicate cookies and bad expiry times * avoid prepending domain with dot for cookies that are set with the server side jar. This is to avoid the cookie being duplicated if it is set or overridden in a different context (request that can actually set the cookie or via document.domain) * feat: use cookie.toString() in the cookie patch to more accurately set cookies on the document, which should include other properties besides key=value * fix: add logic to handle expired cookies in the document.cookie patch, as well as in CDP * chore: build binary for cookie fixes for users to test * chore: change name of fixture to something more accurate * chore: comment why we are using the toughCookie toString method in the patch * [run ci] * chore: add changelog entry * [run ci] * fix: revert back to key=value when getting document.cookie as those are the only values are displayed (oversight on my end) * [run ci] * chore: make compatible with cypress.require * fix: add tests for hostOnly/non hostOnly cookies to make sure property gets sent up to automation client correctly. No longer need custom cookie prop to determine destination * [run ci] * fix: stale unit test * chore: adjust comments * [run ci] * fix: bad domain logic * [run ci] * chore: remove irrelevant comment * [run ci] * fix: adjust cookie login text to spec hostOnly cookie within the cookie patch. This should yield the same behavior as we are bound to same origin within the spec bridge * [run ci] * [run ci] * fix: allow for cookies on request of same key to take precedence over cookies in the jar, regardless of how many hierachy cookies exist in the jar * chore: fix cookie misc tests for cy.origin (dont run cy.origin) * [run ci] * chore: skip misc cookie tests in webkit as headless behavior doesn't clear cookies between tests correctly * Revert "fix: allow for cookies on request of same key to take precedence over cookies in the jar, regardless of how many hierachy cookies exist in the jar" This reverts commit 17de188. * [run ci] * chore: split changelog entry into two parts * chore: update logic to remove else statement and add comments * [run ci] * chore: readd windows snapshot branch in workflows * [run ci] * chore: fix workflows from bad merge * [run ci] * Revert "chore: split changelog entry into two parts" This reverts commit 4352ef5. * [run ci] * fix: Fix type definitions for cy.reload() (#25779) Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> * misc: Debug header updates (#25823) * fix: allow running tests outside Vite project root folder (#25801) * fix: allow running tests outside Vite project root folder * update snapshots * add changelog entry --------- Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * fix: mount component in [data-cy-root] (#25807) * fix(angular): mount component in [data-cy-root] * fix e2e test * add changelog entry * changelog [skip ci] * changelog --------- Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * chore: updating add to triage baord github action to use org secret (#25868) * chore: updating add to triage board github action to use org secret * chore: release @cypress/angular-v2.0.2 [skip ci] * chore: release @cypress/vite-dev-server-v5.0.3 [skip ci] * chore: Update v8 snapshot cache (#25822) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <ryanm@cypress.io> * feat: support host only cookies (#25853) * feat: allow setCookie API to take a hostOnly option * chore: add jsdoc/typescript description to render to users * chore: add changelog entry * [run ci] * chore: fix types * chore: fix cookie login tests * chore: update e2e cookie system tests * [run ci] * chore: fix cookie command tests. localhost cookies are calculated as hostOnly, which is consistent with how cypress works today * chore: fix system tests for cookies. * [run ci] * chore: fix system tests * chore: skip hostOnly assertions in webkit (for now) * [run ci] * chore: add property definitions to setCookieOptions * [run ci] * chore: add comments to hostOnly prop in firefox when setting a cookie * fix(webpack-dev-server): touch component-index during onSpecsChange to avoid writing to app file (#25861) * testing: try disabling uTimesSync and see what happens * build binaries [run ci] * fix: touch component index file instead of browser.js * build binaries [run ci] * update test * fix test * add test for custom HTML file in config * use existing component index in webpack-dev-server unit tests --------- Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * chore: release @cypress/webpack-dev-server-v3.2.4 [skip ci] * chore: improve types for server automation cookie client (#25836) * chore: improve types for automation cookies * [run ci] * fix: the cookie_behavior tests by syncing cookies immediately if … (#25855) * fix: fix the cookie_behavior tests by syncing cookies immediately if the application is already stable * chore: add changelog entry * [run ci] * chore: address comments from code review * feat: Public API for CT Framework Definitions (#25780) * chore: rework component onboarding in launchpad (#25713) * chore: refactoring and types * rework source of frameworks * revert rename * fix tests * fix more tests * types * update code * use same public API internally * rename interfaces * rename * work on dev server api * fix types * fix test * attempt to support getDevServerConfig * tests * add function to define framework [skip ci] * rework a lot of types * fix test * update tests and types * refactor * revert changes * lint * fix test * revert * remove * add "community" label [skip ci] * refactor * types * lint * fix bug * update function name * address feedback * improve types with Pick * refactor using type guard * correct label --------- Co-authored-by: Zachary Williams <ZachJW34@gmail.com> * chore: typing error * feat: scan for 3rd party ct plugins (#25749) * chore: refactoring and types * rework source of frameworks * revert rename * fix tests * fix more tests * types * update code * use same public API internally * rename interfaces * rename * work on dev server api * fix types * fix test * attempt to support getDevServerConfig * tests * add function to define framework [skip ci] * rework a lot of types * fix test * update tests and types * refactor * revert changes * lint * fix test * revert * remove * add "community" label [skip ci] * refactor * types * lint * fix bug * update function name * address feedback * feat: scan for 3rd party ct plugins * add e2e test * unit tests [run ci] * tweak resolution * rebase, address comments * fix windows paths * remove .gitignore * fix test --------- Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com> * lint config * spacing * try fix race cond * fix import error * build binary * try update snapshot * try using require * support namespaced definitions (#25804) * remove category * add icon prop * support esm -> cjs compiled typescript * fix test * misc: add CTA footer to launchpad framework dropdown (#25831) * remove test project dependencies * rebase * windows * windows again * add changelog entry * changelog * revert workflow * remove worklfow --------- Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Adam Stone-Lord <adams@cypress.io> * chore: release @cypress/webpack-dev-server-v3.3.0 [skip ci] * fix: Add missing error message when `req.continue` is used incorrectly (#25884) --------- Co-authored-by: Adam Stone-Lord <adams@cypress.io> Co-authored-by: Zachary Williams <ZachJW34@gmail.com> Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com> Co-authored-by: Matt Schile <mschile@cypress.io> Co-authored-by: Alejandro Estrada <estrada9166@gmail.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com> Co-authored-by: Ryan Pei <ryanppei@gmail.com> Co-authored-by: Emily Rohrbough <emilyrohrbough@yahoo.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <ryanm@cypress.io> Co-authored-by: cypress-bot[bot] <47117332+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Mark Noonan <mark@cypress.io> Co-authored-by: Stokes Player <stokes@cypress.io> Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com> Co-authored-by: Zach Bloomquist <git@chary.us> Co-authored-by: willmsC <50909991+willmsC@users.noreply.github.com> Co-authored-by: Zach Bloomquist <github@chary.us> Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Griesser <tgriesser10@gmail.com> Co-authored-by: Matt Henkes <mjhenkes@gmail.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Ben M <benm@cypress.io> Co-authored-by: Bill Glesias <bglesias@gmail.com> Co-authored-by: Podles <78863563+podlesny-j@users.noreply.github.com> Co-authored-by: Paolo Caleffi <p.caleffi@dreamonkey.com> Co-authored-by: Lachlan Miller <lachlan.miller.1990@outlook.com>

lmiller1990 added 29 commits February 3, 2023 12:48

chore: refactoring and types

b920973

rework source of frameworks

9af7df5

revert rename

b0e6a54

fix tests

8685358

Merge remote-tracking branch 'origin/develop' into lmiller/ct-public-…

7f46405

…api-refactor

fix more tests

bd446d7

types

169fd2d

update code

9a58381

use same public API internally

fe5c399

Merge remote-tracking branch 'origin/develop' into lmiller/ct-public-…

04eff95

…api-refactor

rename interfaces

c9dc13b

rename

57a8c33

work on dev server api

9582e8d

fix types

aa03f22

fix test

55eeadf

attempt to support getDevServerConfig

2c722c3

tests

6c73ff5

add function to define framework [skip ci]

7d3535f

rework a lot of types

2ae85c0

fix test

b8ff1a0

update tests and types

e9257c7

Merge remote-tracking branch 'origin/feature/ct-public-api' into lmil…

681294a

…ler/ct-public-api-refactor

refactor

08dba6b

revert changes

1d959ae

lint

3dbd6c1

fix test

54fee26

revert

b441be4

remove

57c2ab9

add "community" label [skip ci]

bf884c7

ZachJW34 requested a review from lmiller1990 February 8, 2023 21:03

lmiller1990 reviewed Feb 9, 2023

View reviewed changes

ZachJW34 commented Feb 9, 2023

View reviewed changes

system-tests/projects/qwik-app/.gitignore Outdated

@@ -0,0 +1,38 @@

# Build

Copy link

Contributor Author

ZachJW34 Feb 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file.

ZachJW34 commented Feb 9, 2023

View reviewed changes

lmiller1990 reviewed Feb 9, 2023

View reviewed changes

lmiller1990 and others added 12 commits February 10, 2023 14:15

refactor

33feea4

types

c8087c1

lint

270e4e7

fix bug

5060900

update function name

6d6d718

Merge branch 'feature/ct-public-api' into lmiller/ct-public-api-refactor

29c8b45

address feedback

08b705a

feat: scan for 3rd party ct plugins

2c3a2d8

add e2e test

a6f1435

unit tests [run ci]

f9e18e9

tweak resolution

6bebdf1

rebase, address comments

e1230b6

ZachJW34 force-pushed the zachw/detect-3rd-party-ct-plugins branch from ccf2815 to e1230b6 Compare February 10, 2023 21:06

fix windows paths

49ab86f

ZachJW34 marked this pull request as ready for review February 10, 2023 22:31

remove .gitignore

0dd9606

Base automatically changed from lmiller/ct-public-api-refactor to feature/ct-public-api February 13, 2023 00:00

lmiller1990 added 2 commits February 13, 2023 10:15

merge in feature/ct-public-api

920b2b2

fix test

ed393e3

lmiller1990 approved these changes Feb 13, 2023

View reviewed changes

Merge branch 'feature/ct-public-api' into zachw/detect-3rd-party-ct-p…

722a247

…lugins

lmiller1990 merged commit 9c94642 into feature/ct-public-api Feb 13, 2023

lmiller1990 deleted the zachw/detect-3rd-party-ct-plugins branch February 13, 2023 01:28

cypress bot mentioned this pull request Feb 13, 2023

feat: Public API for CT Framework Definitions #25780

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: scan for 3rd party ct plugins #25749

feat: scan for 3rd party ct plugins #25749

ZachJW34 commented Feb 8, 2023 •

edited

lmiller1990 left a comment

lmiller1990 Feb 9, 2023

ZachJW34 Feb 9, 2023

lmiller1990 Feb 9, 2023

lmiller1990 Feb 9, 2023

ZachJW34 Feb 9, 2023

lmiller1990 Feb 9, 2023

ZachJW34 Feb 9, 2023

lmiller1990 Feb 9, 2023

ZachJW34 Feb 9, 2023

lmiller1990 Feb 9, 2023

ZachJW34 Feb 9, 2023

lmiller1990 Feb 9, 2023

lmiller1990 Feb 9, 2023

lmiller1990 Feb 9, 2023

lmiller1990 Feb 9, 2023

ZachJW34 Feb 9, 2023

ZachJW34 Feb 9, 2023

ZachJW34 Feb 9, 2023

lmiller1990 Feb 9, 2023

lmiller1990 left a comment


		debug('Attempting to resolve third party module with require.resolve: %s', packageRoot)

		const modulePath = require.resolve(packageRoot)


		mountModule: (projectPath) => Promise.resolve('cypress-ct-qwik'),

		icon: '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 166 155.3"><defs><linearGradient id="a" gradientUnits="userSpaceOnUse" x1="27.5" y1="3" x2="152" y2="63.5"><stop offset=".1" stop-color="#76b3e1"/><stop offset=".3" stop-color="#dcf2fd"/><stop offset="1" stop-color="#76b3e1"/></linearGradient><linearGradient id="b" gradientUnits="userSpaceOnUse" x1="95.8" y1="32.6" x2="74" y2="105.2"><stop offset="0" stop-color="#76b3e1"/><stop offset=".5" stop-color="#4377bb"/><stop offset="1" stop-color="#1f3b77"/></linearGradient><linearGradient id="c" gradientUnits="userSpaceOnUse" x1="18.4" y1="64.2" x2="144.3" y2="149.8"><stop offset="0" stop-color="#315aa9"/><stop offset=".5" stop-color="#518ac8"/><stop offset="1" stop-color="#315aa9"/></linearGradient><linearGradient id="d" gradientUnits="userSpaceOnUse" x1="75.2" y1="74.5" x2="24.4" y2="260.8"><stop offset="0" stop-color="#4377bb"/><stop offset=".5" stop-color="#1a336b"/><stop offset="1" stop-color="#1a336b"/></linearGradient></defs><path d="M163 35S110-4 69 5l-3 1c-6 2-11 5-14 9l-2 3-15 26 26 5c11 7 25 10 38 7l46 9 18-30z" fill="#76b3e1"/><path d="M163 35S110-4 69 5l-3 1c-6 2-11 5-14 9l-2 3-15 26 26 5c11 7 25 10 38 7l46 9 18-30z" opacity=".3" fill="url(#a)"/><path d="M52 35l-4 1c-17 5-22 21-13 35 10 13 31 20 48 15l62-21S92 26 52 35z" fill="#518ac8"/><path d="M52 35l-4 1c-17 5-22 21-13 35 10 13 31 20 48 15l62-21S92 26 52 35z" opacity=".3" fill="url(#b)"/><path d="M134 80a45 45 0 00-48-15L24 85 4 120l112 19 20-36c4-7 3-15-2-23z" fill="url(#c)"/><path d="M114 115a45 45 0 00-48-15L4 120s53 40 94 30l3-1c17-5 23-21 13-34z" fill="url(#d)"/></svg>',

feat: scan for 3rd party ct plugins #25749

feat: scan for 3rd party ct plugins #25749

Conversation

ZachJW34 commented Feb 8, 2023 • edited

Additional details

Steps to test

How has the user experience changed?

PR Tasks

lmiller1990 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmiller1990 left a comment

Choose a reason for hiding this comment

ZachJW34 commented Feb 8, 2023 •

edited