dependency: update mocha-junit-reporter to 2.2.0 #25922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 failed and 26 flaky tests on run #44329 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| cy.origin waiting > alias > waits for the route alias to have a response | ||
e2e/origin/cookie_login.cy.ts • 1 flaky test • 5x-driver-electron
| Test | ||
|---|---|---|
| cy.origin - cookie login > Max-Age > past max-age -> not logged in | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | ||
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse | ||
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | ||
|---|---|---|
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
| ... > correctly returns currentRetry | ||
create-from-component.cy.ts • 1 flaky test • app-e2e
| Test | ||
|---|---|---|
| ... > runs generated spec |
Screenshot
|
|
The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
@AlexGuironnetRTE Changes look good! Can you add a changelog entry for the dependency update so users are away this has bumped? |
emilyrohrbough
changed the title
|
Thanks for the review! I added the changelog entry, sorry I missed it. I didn't realize that a dependency update qualified as a user-facing change but that makes sense. |
emilyrohrbough
approved these changes
Mar 2, 2023
|
@AlexGuironnetRTE thank you!! |
mike-plummer
approved these changes
Mar 2, 2023
|
@AlexGuironnetRTE Thank you for the contribution! 🎉 This will go out in our next release in the next two weeks or so |
|
@emilyrohrbough @mike-plummer Awesome! Thanks a lot for integrating it so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Version 2.2.0 of mocha-junit-reporter provides new placeholders to define the report file name
Steps to test
N/A
How has the user experience changed?
N/A
PR Tasks
cypress-documentation?type definitions?