-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-dev-server): Pass in jsconfig to get webpack config for Next.js >= 13.2.1 #26005
Conversation
…r Next.js >= 13.2.1
Thoughts about testing this with a system test? I looked into it for a while but was having some problems and started questioning whether or not it would be worth the effort. I was able to test it pretty well manually using some example projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a system-test covering this would be beneficial
5 flaky tests on run #44547 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
Video
|
e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
cy.origin navigation > #consoleProps > .go() |
Output
Video
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
|
... > correctly returns currentRetry |
Output
Video
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
I'm following the directions to test and trying a couple of things, but I consistently get
I wonder if I am missing some little detail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed this works as expected for me. +1 to a system test
Additional details
With the release of Next.js 13.2.1, we need to pass the JS/TS config into
getBaseWebpackConfig
, otherwise the config won't be respected when running the dev server. This PR adds some logic to get the user's JS/TS configuration and pass it togetBaseWebpackConfig
.Steps to test
src/
dir (it's in the generator options)cypress/support/component.ts
, import a stylesheet like thisAlso test on < v13.2.1 and make sure that everything still works.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?