Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update npm/vue to use latest test utils #26633

Merged
merged 4 commits into from
May 3, 2023
Merged

Conversation

lmiller1990
Copy link
Contributor

Additional details

Just updated the underlying vue/test-utils dependency to get some of the latest features, specifically, access variables declared and exposed via defineExpose.

I also fixed a bug where some of the Vue core code was incorrect bundled in the cypress/vue bundle. I fixed this by updating the external key in the rollup config. If you do cd npm/vue && yarn build && wc -l dist/cypress-vue.esm-bundler.js before and after, you'll see around 5k lines difference.

Steps to test

You can run the new test if you want, but as long as CI is passing, everything is 💯 . This is just a dependency update.

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented May 1, 2023

4 flaky tests on run #45951 ↗︎

0 5193 77 0 Flakiness 4

Details:

improve changelog and test
Project: cypress Commit: 543437d762
Status: Passed Duration: 14:30 💡
Started: May 2, 2023 1:54 AM Ended: May 2, 2023 2:08 AM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the code side, just a couple minor tweaks needed

npm/vue/cypress/component/setup/HelloWorld.cy.ts Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@mike-plummer mike-plummer requested a review from a team May 1, 2023 19:26
@mike-plummer mike-plummer requested a review from a team May 2, 2023 13:12
@lmiller1990 lmiller1990 merged commit 234681f into develop May 3, 2023
75 of 77 checks passed
@lmiller1990 lmiller1990 deleted the issue-26575 branch May 3, 2023 00:14
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 12, 2023

Released in 12.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants