-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update npm/vue to use latest test utils #26633
Conversation
4 flaky tests on run #45951 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the code side, just a couple minor tweaks needed
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
script setup
component are not accessible on the component instance (AKAwrapper.vm
) #26575Additional details
Just updated the underlying
vue/test-utils
dependency to get some of the latest features, specifically, access variables declared and exposed viadefineExpose
.I also fixed a bug where some of the Vue core code was incorrect bundled in the
cypress/vue
bundle. I fixed this by updating theexternal
key in the rollup config. If you docd npm/vue && yarn build && wc -l dist/cypress-vue.esm-bundler.js
before and after, you'll see around 5k lines difference.Steps to test
You can run the new test if you want, but as long as CI is passing, everything is 💯 . This is just a dependency update.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?