Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert #26452 (Yarn Plug n Play compat regression) #26735

Merged
merged 3 commits into from
May 12, 2023

Conversation

lmiller1990
Copy link
Contributor

This reverts commit 7a33f5c. It introduced a regression, #26676, for which I couldn't find a timely fix. The regression only manifests when using the binary - which is why it wasn't caught in the code review, we did not test the binary for that PR.

Let's revert this until we have ironed out all the Yarn 3 issues.

Additional details

Reverted an older commit. I did it like this:

git revert --strategy resolve 7a33f5c1a87f5a3aa3b8da575b39e42f93bfd5db

Steps to test

Not sure we need to test a revert - it we do, we'd need to build a binary and initialize a new E2E project using Yarn 3.

How has the user experience changed?

Clean commit revert. No change in experience other than removing the code that led to a regression. The original bug it tried to fix (CT onboarding with Yarn PnP) is back, but that's not a blocker - you can still hit "skip" and do the CT setup.

PR Tasks

@lmiller1990 lmiller1990 marked this pull request as ready for review May 11, 2023 23:07
@lmiller1990 lmiller1990 requested review from chrisbreiding and a team May 11, 2023 23:07
@lmiller1990 lmiller1990 changed the title fix: revert #26452 (Plug n Play) fix: revert #26452 (Yarn Plug n Play compat regression) May 11, 2023
@cypress
Copy link

cypress bot commented May 11, 2023

5 flaky tests on run #46241 ↗︎

0 5193 77 0 Flakiness 5

Details:

changelog
Project: cypress Commit: 5f2b03da26
Status: Passed Duration: 13:49 💡
Started: May 12, 2023 9:40 AM Ended: May 12, 2023 9:54 AM
Flakiness  commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
... > can timeout when retrieving upstream response Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn Modern (3) using default pnp hangs at Initializing config...
3 participants