Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct typescript scaffold dependency #26815

Merged
merged 5 commits into from
May 22, 2023
Merged

fix: Correct typescript scaffold dependency #26815

merged 5 commits into from
May 22, 2023

Conversation

dkasper-was-taken
Copy link
Contributor

@dkasper-was-taken dkasper-was-taken commented May 19, 2023 •
edited

Additional details

Steps to test

  • Make a new folder
  • yarn init in new directory
  • npm i typescript -D in new directory
  • Open this new folder in global mode from this branch
  • Select Component Testing
  • Select a Framework
  • Validate 5.0.0 is supported

Screen Shot 2023-05-19 at 3 14 23 PM

How has the user experience changed?

PR Tasks

  • [n/a] Have tests been added/updated? Will be added in future PR
  • [n/a] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@CLAassistant
Copy link

CLAassistant commented May 19, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@dkasper-was-taken dkasper-was-taken self-assigned this May 19, 2023
@dkasper-was-taken dkasper-was-taken changed the title Ct 26204 typescript config fix Fix: Correct typescript scaffold dependency May 19, 2023
@dkasper-was-taken dkasper-was-taken changed the title Fix: Correct typescript scaffold dependency fix: Correct typescript scaffold dependency May 19, 2023
@cypress
Copy link

cypress bot commented May 19, 2023 •
edited

Passing run #46672 ↗︎

0 214 20 0 Flakiness 0

Details:

Merge branch 'develop' into ct-26204-typescript-config-fix
Project: cypress Commit: 8bb238e266
Status: Passed Duration: 10:05 💡
Started: May 22, 2023 8:38 PM Ended: May 22, 2023 8:48 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@dkasper-was-taken dkasper-was-taken marked this pull request as ready for review May 22, 2023 15:38
@dkasper-was-taken dkasper-was-taken requested a review from a team May 22, 2023 15:42
mike-plummer
mike-plummer requested changes May 22, 2023
View reviewed changes
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@dkasper-was-taken @mike-plummer
Update change log for PR comment
e3c5f97 
Co-authored-by: Mike Plummer <mike-plummer@users.noreply.github.com>
@dkasper-was-taken dkasper-was-taken merged commit e821f85 into develop May 22, 2023
77 of 78 checks passed
@dkasper-was-taken dkasper-was-taken deleted the ct-26204-typescript-config-fix branch May 22, 2023 21:09
@cypress cypress bot mentioned this pull request May 23, 2023
Merged
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike-plummer mike-plummer mike-plummer approved these changes

@astone123 astone123 astone123 approved these changes

Assignees

@dkasper-was-taken dkasper-was-taken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component Testing: typescript ^=5.0.0 support
5 participants
@dkasper-was-taken @CLAassistant @mike-plummer @astone123 @marktnoonan