secure cookie error crash #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
brian-mann
commented
Oct 31, 2018
•
brian-mann
commented
- fixes Cypress crashes when a site uses secure cookies #1264
- fixes Cypress crash: Error: Failed to parse or set cookie named #1321
- fixes Failed to parse or set cookie named "X-PP-SILOVER" error. #1799
- fixes Add .vscode to git for project specific tasks, debuggers, settings, and terminals #2689
- fixes Update ESlint development rules #2688
- fixes Convert all packages/server/lib/util from CS to JS #2687
- fixes Add decaffeinate and bulk-decaffeinate to start conversion to JS #2686
- for special use in vscode, although useful outside it too
- this fixes the edge case where a secure cookie flag is set and then that cookie is then expired from an https URL *without* the subsequent secure flag - due to the way we were constructing the URL, this would fail to actually remove the cookie
Merged
kuceb
added a commit
to kuceb/cypress
that referenced
this pull request
Apr 23, 2019
This reverts commit 2333d04.
kuceb
pushed a commit
to kuceb/cypress
that referenced
this pull request
Apr 23, 2019
- fixes cypress-io#1264 - fixes cypress-io#1321 - fixes cypress-io#1799 - fixes cypress-io#2689 - fixes cypress-io#2688 - fixes cypress-io#2687 - fixes cypress-io#2686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.