Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: video compression false #27009

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Jun 13, 2023

Additional details

For Cypress v13 , video will be set to false by default. In addition, we will also be setting videoCompression to false. This PR implements those changes.

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker
Copy link
Contributor Author

weird thought I committed these 😅

cli/CHANGELOG.md Outdated Show resolved Hide resolved
cli/CHANGELOG.md Outdated Show resolved Hide resolved
@AtofStryker AtofStryker force-pushed the feat/set_video_false branch 2 times, most recently from 129a152 to a66b1fe Compare June 16, 2023 19:03
Base automatically changed from feat/set_video_false to release/13.0.0 June 20, 2023 17:21
Update system-tests/projects/ts-proj-5/cypress.config.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/vite-simple/cypress.config.js

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/react-vite-ts-configured/cypress.config.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/svelte-vite/cypress.config.js

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/ts-proj-4-5/cypress.config.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/webpack-dev-server-ts/cypress.config.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/vue3-vite-ts-configured/cypress.config.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update system-tests/projects/vue3-vite-ts-custom-index-html/cypress.config.ts

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update cli/CHANGELOG.md

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>

Update cli/CHANGELOG.md

Co-authored-by: Emily Rohrbough <emilyrohrbough@users.noreply.github.com>
@AtofStryker AtofStryker force-pushed the breaking/video_compression_false branch from 50609b0 to 1d57c26 Compare June 20, 2023 18:07
@AtofStryker AtofStryker merged commit 9e698ce into release/13.0.0 Jun 20, 2023
76 of 78 checks passed
@AtofStryker AtofStryker deleted the breaking/video_compression_false branch June 20, 2023 19:08
@cypress
Copy link

cypress bot commented Jun 20, 2023

14 flaky tests on run #47919 ↗︎

0 14750 1061 0 Flakiness 14

Details:

breaking: set videoCompression to false by default
Project: cypress Commit: 1d57c2621d
Status: Passed Duration: 14:03 💡
Started: Jun 20, 2023 6:55 PM Ended: Jun 20, 2023 7:09 PM
Flakiness  e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
user agent override > persists modified user agent after cy.go Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome

View Output Video

Test Artifacts
network stubbing > waiting and aliasing > can timeout waiting on a single response using "alias" Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  commands/net_stubbing.cy.ts • 3 flaky tests • 5x-driver-webkit

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
... > with `times` > only uses each handler N times Output
... > stops waiting when an xhr request is canceled Output

The first 5 flaky specs are shown, see all 6 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress cypress bot mentioned this pull request Jun 20, 2023
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants