chore: notification telemetry #27026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 flaky tests on run #48117 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Output
Screenshots
Video
|
|
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Output
Screenshots
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws waiting for the 3rd response |
Output
|
|
The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
lmiller1990
commented
Jun 15, 2023
|
This looks like it will take some sort of Cloud work to implement. Please see internal Slack initiative channel for more details. For now, moving this back to 'draft' state. |
lmiller1990
commented
Jun 23, 2023
| if (!this.projectBase) { | ||
| debug('No projectBase, cannot change url') | ||
|
|
||
| return | ||
| } | ||
|
|
||
| const newUrl = `#/debug` | ||
| const params = JSON.stringify({ from: 'notification', runNumber }) |
There was a problem hiding this comment.
Neat idea to pass it through here.
lmiller1990
commented
Jun 23, 2023
There was a problem hiding this comment.
This looks much cleaner now, thank you @warrensplayer.
It looks like we collect a lot less telemetry than initially - great to see. This looks good to me. I gave it a small test. Let's merge this up and move onto the final QA / acceptance testing.
lmiller1990
merged commit ccfdeef
into
feature/run-notifications-m1
76 of 78 checks passed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Capture some non-intrusive and non identifying telemetry for App Notifications.
Steps to test
There are two ways a user might navigate to the Debug page:
We want to capture how the user is navigating to the Debug page. That's what you are testing here.
The easiest way to do this is to turn on debugging for
cypress:data-context:actions:EventCollectorActionsand look for a message that saysRecorded machine-linkedwith the expected event info.Then you can trigger the event like this:
source: sidebar- just click the Debug icon in from the App. It will launch a mutation that eventually calls therecordEventaction.source: notification. This is a bit more tricky. You'll need to trigger a notification. You can see how to do that by looking at this PRs test plan. Once you click a notification, it should also record the event with the correctmedium.Example:
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?