Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update messages to only show user options #2708

Closed
wants to merge 2 commits into from
Closed

Conversation

lilaconlee
Copy link
Contributor

There are a couple other places where this happens but wanted to double check that this is an okay way to address it before I got too far on the others.

@jennifer-shehane
Copy link
Member

Hey @lilaconlee, I see the last commit to this PR was in November. Can you clarify what is blocking getting this out of WIP?

@lilaconlee
Copy link
Contributor Author

Yeah! This is WIP because I wanted to get the strategy reviewed before implementing it in more than one command.

I think focusing on 4.0 work would be better at the moment, so I'm gonna close this for now and we can re-open/re-apply this logic in another PR if we want to pick it up again.

@lilaconlee lilaconlee closed this Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants