fix: retain original array after defaultsDeep #27240 #27312
Merged
+51
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 flaky tests on run #54622 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| ... > establishes a session |
| |||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > passes through assertion error when not about existence |
Test Replay
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| network stubbing > waiting and aliasing > yields the expected interception when two requests are raced |
Test Replay
|
|
commands/querying/querying.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws when alias property is `0` |
Test Replay
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when waiting for 2nd response to route |
Test Replay
|
|
The first 5 flaky specs are shown, see all 7 specs in Cypress Cloud.
Review all test suite changes for PR #27312 ↗︎
|
@NiharPhansalkar #27240 kept failing - I made a new branch and it passes fine, I am not sure why. I've seen this happen before -- some CI weirdness. Can you approve this? I left an approval on your original PR, but had to remake it. You'll still get credit, your commits are here. |
|
Sure will approve! |
NiharPhansalkar
approved these changes
Jul 17, 2023
|
This PR has not had any activity in 180 days. If no activity is detected in the next 14 days, this PR will be closed. |
cacieprins
approved these changes
Mar 14, 2024
AtofStryker
approved these changes
Mar 14, 2024
AtofStryker
reviewed
Mar 22, 2024
packages/app/cypress/e2e/subscriptions/specChange-subscription.cy.ts
Outdated
Show resolved
Hide resolved
AtofStryker
force-pushed
the
lmiller/issue-27103
branch
from
2b3995e
to
7b8dc96
Compare
3 tasks
cacieprins
added a commit
that referenced
this pull request
Mar 26, 2024
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
cacieprins
added a commit
that referenced
this pull request
Mar 26, 2024
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
cacieprins
added a commit
that referenced
this pull request
Mar 26, 2024
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
cacieprins
added a commit
that referenced
this pull request
Mar 26, 2024
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
cacieprins
added a commit
that referenced
this pull request
Mar 26, 2024
* modifying object after array combination to hold older values * regression test * made suggested changes * config defaults * log * logs * log * log again * update log * changelog * updates changelog * fix typo and move changelog entry and fix link --------- Co-authored-by: Nihar Phansalkar <phansalkarnihar@gmail.com> Co-authored-by: Jennifer Shehane <jennifer@cypress.io> Co-authored-by: Cacie Prins <cacieprins@users.noreply.github.com> Co-authored-by: Cacie Prins <cacie@cypress.io> Co-authored-by: AtofStryker <bglesias@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
specPatterndoesn't yield error ifspecPatternwas originally an array #27103note remaking - original PR #27312 got stuck on red on CI, I could not get it to pass. New branch is fine 🤷
Additional details
What is affected by this change?Previously the defaultsDeep function was merging/combining arrays. This PR will fix that issue and restore any arrays modified by the
setupNodeEventsfunction.Steps to test
To test, copy the cypress.config.js from the
reproductionsection of the issue and configure for e2e testing. Then run cypress usingyarn cypress open --dev --config-file cypress.config.js. After setting any key within the config object to any array value (within the setupNodeEvents function), it should reflect as is in the final config.How has the user experience changed?
User will get the exact config they supply in the
setupNodeEventsfunction.PR Tasks
cypress-documentation?type definitions?