Skip to content

feat: protocol terminal output#27402

Merged
cacieprins merged 51 commits into
release/13.0.0from
cacie/feat/protocol-terminal-output
Aug 10, 2023
Merged

feat: protocol terminal output#27402
cacieprins merged 51 commits into
release/13.0.0from
cacie/feat/protocol-terminal-output

Conversation

@cacieprins

@cacieprins cacieprins commented Jul 26, 2023

Copy link
Copy Markdown
Collaborator

Updates terminal output for upload manifests and results. Files that will be uploaded show how large the file is, and issues encountered while uploading show on the upload results list. When test replay is unavailable due to being disabled on the project, or if specs are run in a non-chromium browser, user is notified via this manifest display with a helpful message.

Additional details

uploadArtifacts was refactored in order to:

  • Collect all filesize information before upload commencement for display in the upload manifest
  • Report on all uploads after completion
  • Create a semi-uniform shape for upload artifacts, so they can be handled similarly
  • Promise callback style converted to async/await for readability

Steps to test

  1. Run spec with test replay enabled
  2. Run spec with test replay disabled
  3. Run spec with firefox
  4. Run spec that generates a db larger than 200 bytes with CYPRESS_INTERNAL_SYSTEM_TESTS set to 1
  5. Force protocol capture code into error state and run spec
  6. Force protocol capture upload endpoint into error state and run spec

How has the user experience changed?

PR Tasks

@cacieprins cacieprins changed the base branch from develop to release/13.0.0 July 26, 2023 18:48
@cacieprins cacieprins force-pushed the cacie/feat/protocol-terminal-output branch from 9d113cd to 0313ce5 Compare July 27, 2023 18:06
@cacieprins cacieprins force-pushed the cacie/feat/protocol-terminal-output branch from 0313ce5 to a62d877 Compare July 27, 2023 18:08
@cacieprins cacieprins marked this pull request as ready for review July 27, 2023 18:45
@cypress

cypress Bot commented Jul 27, 2023

Copy link
Copy Markdown

2 flaky tests on run #49727 ↗︎

0 695 26 0 Flakiness 2

Details:

rm commented code from protocol stub
Project: cypress Commit: acf5eec5a3
Status: Passed Duration: 12:50 💡
Started: Aug 10, 2023 5:18 PM Ended: Aug 10, 2023 5:30 PM
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Test Replay Output Screenshots
Flakiness  studio/studio.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress Studio > updates an existing test with a click action Test Replay Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Comment thread packages/server/lib/cloud/protocol.ts
Comment thread packages/server/lib/modes/record.js Outdated
@cacieprins cacieprins marked this pull request as draft July 28, 2023 19:42
@cacieprins cacieprins marked this pull request as ready for review August 2, 2023 19:36
@cacieprins cacieprins marked this pull request as draft August 3, 2023 13:44
@cacieprins cacieprins marked this pull request as ready for review August 4, 2023 20:03
@AtofStryker AtofStryker self-requested a review August 7, 2023 15:37
Comment thread packages/server/lib/cloud/api.ts Outdated

@AtofStryker AtofStryker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly questions as I learn some of the protocol system test stuff. Nice work on getting these updated!

Comment thread packages/server/lib/util/print-run.ts Outdated
Comment thread packages/server/lib/util/print-run.ts Outdated
Comment thread packages/server/lib/util/print-run.ts Outdated
Comment thread packages/server/lib/util/print-run.ts
Comment thread packages/server/lib/util/print-run.ts
Comment thread system-tests/__snapshots__/record_spec.js Outdated
Comment thread system-tests/lib/protocolStubResponse.ts
Comment thread system-tests/lib/protocolStubWithRuntimeErrors.ts Outdated
Comment thread packages/server/lib/cloud/protocol.ts
Comment thread packages/server/lib/modes/record.js

@ryanthemanuel ryanthemanuel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I played around with this locally and branched off of it for some of my changes and it is working well: #27462. Nice work!

@AtofStryker AtofStryker self-requested a review August 9, 2023 21:22
Comment thread system-tests/lib/protocolStub.ts Outdated
@cacieprins cacieprins merged commit fff7490 into release/13.0.0 Aug 10, 2023
@cacieprins cacieprins deleted the cacie/feat/protocol-terminal-output branch August 10, 2023 17:49
@cypress cypress Bot mentioned this pull request Aug 10, 2023
3 tasks
@jennifer-shehane

Copy link
Copy Markdown
Member

Released in Cypress 13.0.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants