chore: modify highlight selector to include frameId #27458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkasper-was-taken
requested review from
cacieprins,
mschile,
AtofStryker and
ryanthemanuel
25 flaky tests on run #49440 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > skips the setup steps when choosing component tests to run |
Test Replay
Output
Screenshots
|
|
e2e/origin/commands/traversal.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin traversal > .children() |
Test Replay
Output
|
|
e2e/origin/dependencies.cy.jsx • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| cy.origin dependencies - jsx > works with a jsx file |
Test Replay
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
| ... > correctly returns currentRetry |
Test Replay
Output
|
|
create-from-component.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Test Replay
Output
Screenshots
|
|
The first 5 flaky specs are shown, see all 13 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
ryanthemanuel
approved these changes
Aug 7, 2023
AtofStryker
reviewed
Aug 8, 2023
|
I had the src file open only 🤦🏻 . everything looks good |
AtofStryker
approved these changes
Aug 8, 2023
mschile
pushed a commit
that referenced
this pull request
Aug 10, 2023
* initial logic for unique frame selector * messy in progress * quick test cleanup, need to figure out stub for meta * update name * stub test metadata * revise key * clean up * debugging change * test for error * test jquery issue * type * revert * update config for test
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update snapshot API to return
elementsToHighlight, an array of objects containing the aselectorandframeId.Additional details
Test replay needs the ability to handle actions/highlights within nested iframes. Currently we are only capturing the selector which is only relative to the AUT frame.
Steps to test
protocolEnabled: trueandnumTestsKeptInMemory: 0either within cypress config or on a individual test runHow has the user experience changed?
PR Tasks
cypress-documentation?type definitions?