Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move entry for #26400 to fix changelog #27467

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

astone123
Copy link
Contributor

Additional details

This PR fixes two issues:

How has the user experience changed?

n/a

PR Tasks

@astone123 astone123 self-assigned this Aug 4, 2023
@@ -86,7 +86,7 @@ const getReleaseData = async (latestReleaseInfo) => {
pull_number: ref.issue,
})

const associatedIssues = getLinkedIssues(pullRequest.body)
const associatedIssues = pullRequest.body ? getLinkedIssues(pullRequest.body) : []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR body is empty, then there aren't any associated issues. Don't throw an error

@cypress
Copy link

cypress bot commented Aug 4, 2023

17 flaky tests on run #49428 ↗︎

0 5806 83 0 Flakiness 17

Details:

add line break
Project: cypress Commit: 986649e5e2
Status: Passed Duration: 16:30 💡
Started: Aug 4, 2023 7:14 PM Ended: Aug 4, 2023 7:31 PM
Flakiness  commands/assertions.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin assertions > .should() and .and() Output Video
Flakiness  commands/navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin navigation > #consoleProps > .go() Output Video
Flakiness  commands/traversal.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin traversal > .children() Output Video
Flakiness  navigation.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
delayed navigation > errors > redirects to an unexpected cross-origin and calls another command in the cy.origin command Output Video
Flakiness  commands/querying.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin querying > .get() Output Video

The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@nagash77 nagash77 merged commit 24c733c into develop Aug 4, 2023
78 of 80 checks passed
@nagash77 nagash77 deleted the astone123/fix-changelog branch August 4, 2023 20:24
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 15, 2023

Released in 12.17.4.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.17.4, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants