-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove flaky Percy snapshot from ConfigCode spec #27532
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
changed the title
Astone123/config code percy flake
chore: remove flaky Percy snapshot from ConfigCode spec
Aug 11, 2023
astone123
force-pushed
the
astone123/config-code-percy-flake
branch
from
August 11, 2023 14:26
0d88381
to
f91adbc
Compare
jordanpowell88
approved these changes
Aug 11, 2023
41 flaky tests on run #49793 ↗︎
Details:
commands/net_stubbing.cy.ts • 2 flaky tests • 5x-driver-electron
e2e/origin/logging.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/commands/actions.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/commands/querying.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/user_agent_override.cy.ts • 1 flaky test • 5x-driver-electron
The first 5 flaky specs are shown, see all 27 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
AtofStryker
approved these changes
Aug 11, 2023
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a flaky Percy snapshot from the CodeConfig spec.
Flake example: https://percy.io/cypress-io/cypress/builds/29576061/changed/1640726573?browser=chrome&browser_ids=38&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=800&widths=800