-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added support for --runner-ui and --no-runner-ui cli options #27582
Conversation
4 flaky tests on run #50156 ↗︎Details:
|
Test | Artifacts | |
---|---|---|
network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta
Test | Artifacts | |
---|---|---|
... > correctly returns currentRetry |
Output
|
|
... > correctly returns currentRetry |
Output
|
|
... > correctly returns currentRetry |
Output
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mschile Are these options also made available in the Module API so that people running in that mode can opt out? (Could be followup to release if that's warranted.)
Yes, the module API is supported through the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When hiding the runner UI, shouldn't we also be preventing events from going to the reporter, like with hideCommandLog: true
? For example, here we don't send the reporter runnables:ready. That improves performance further since the reporter doesn't instantiate a bunch of its own state based off of that.
When |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
--runner-ui
and--no-runner-ui
runnerUi
parameter to the module API--runner-ui
will override this behavior and show the runnerSteps to test
--no-runner-ui
and verify the runner is not displayed--runner-ui
and verify the runner is displayedHow has the user experience changed?
Protocol enabled (runner is hidden by default):
![Screenshot 2023-08-17 at 11 42 18 AM](https://private-user-images.githubusercontent.com/2002044/261391149-a629acae-7abb-408c-8e5a-8c644cc656da.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjg4OTUsIm5iZiI6MTcyMTIyODU5NSwicGF0aCI6Ii8yMDAyMDQ0LzI2MTM5MTE0OS1hNjI5YWNhZS03YWJiLTQwOGMtOGU1YS04YzY0NGNjNjU2ZGEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTdUMTUwMzE1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGVlMTc2NzdjMWU1N2M3YWM4NTM1OTJlMzQ2YzJiMDI5NWQ4MmFhOTMyN2VmOGRlZjFkYzBlN2FmMGFmNjdmNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.DDEWi0Nf0prpkqQXMB-nYn0GnteIGXnljfTi3NrZhFg)
Protocol enabled passing
![Screenshot 2023-08-17 at 11 43 15 AM](https://private-user-images.githubusercontent.com/2002044/261391359-89570c82-3c0b-47db-8c5d-eba0ddc321d9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjg4OTUsIm5iZiI6MTcyMTIyODU5NSwicGF0aCI6Ii8yMDAyMDQ0LzI2MTM5MTM1OS04OTU3MGM4Mi0zYzBiLTQ3ZGItOGM1ZC1lYmEwZGRjMzIxZDkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTdUMTUwMzE1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZGExZDU3MWI2ZTQwODRlN2E1NDc4ZWQ3NWQyYjgyMDFlNjc2MWQ4N2UwNDlmNDc0MjAxNGU0NDUxZjllMTUxMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.8E_7mhKR4yHvwwbEwM8zcxEwA6xgArOn9B7ZuILMpeU)
--runner-ui
PR Tasks
cypress-documentation
?type definitions
?