Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added support for --runner-ui and --no-runner-ui cli options #27582

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Aug 17, 2023

Additional details

  • Added new run mode cli only options, --runner-ui and --no-runner-ui
  • Added new runnerUi parameter to the module API
  • In addition to hiding the command log, when the runner is hidden, the runner header is also hidden.
  • If the protocol is enabled, the runner is hidden:
    • passing --runner-ui will override this behavior and show the runner

Steps to test

  • In run mode, pass --no-runner-ui and verify the runner is not displayed
  • With protocol enabled, pass --runner-ui and verify the runner is displayed

How has the user experience changed?

Protocol enabled (runner is hidden by default):
Screenshot 2023-08-17 at 11 42 18 AM

Protocol enabled passing --runner-ui
Screenshot 2023-08-17 at 11 43 15 AM

PR Tasks

@cypress
Copy link

cypress bot commented Aug 17, 2023

4 flaky tests on run #50156 ↗︎

0 5332 82 0 Flakiness 4

Details:

Merge branch 'release/13.0.0' into mschile/protocol/no_runner_ui
Project: cypress Commit: cb6ed1cebb
Status: Passed Duration: 12:48 💡
Started: Aug 18, 2023 8:57 PM Ended: Aug 18, 2023 9:09 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-chrome:beta

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome:beta

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mschile Are these options also made available in the Module API so that people running in that mode can opt out? (Could be followup to release if that's warranted.)

@mschile
Copy link
Contributor Author

mschile commented Aug 17, 2023

@mschile Are these options also made available in the Module API so that people running in that mode can opt out? (Could be followup to release if that's warranted.)

Yes, the module API is supported through the runnerUi parameter. In this case, the user would provide true/false for the parameter similar to the exit parameter.

Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When hiding the runner UI, shouldn't we also be preventing events from going to the reporter, like with hideCommandLog: true? For example, here we don't send the reporter runnables:ready. That improves performance further since the reporter doesn't instantiate a bunch of its own state based off of that.

@mschile
Copy link
Contributor Author

mschile commented Aug 18, 2023

When hiding the runner UI, shouldn't we also be preventing events from going to the reporter, like with hideCommandLog: true? For example, here we don't send the reporter runnables:ready. That improves performance further since the reporter doesn't instantiate a bunch of its own state based off of that.

When hideRunnerUi is set, I also set hideCommandLog, so this will still happen.

@mschile mschile merged commit c1a8004 into release/13.0.0 Aug 18, 2023
79 of 81 checks passed
@mschile mschile deleted the mschile/protocol/no_runner_ui branch August 18, 2023 22:32
@cypress cypress bot mentioned this pull request Aug 18, 2023
3 tasks
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants