-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: SEC-688 | Update to the SCA scan action for Snyk #27614
Conversation
@cypresschris can you update the title of the PR to start with |
Yes, done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, make sure to prefix the squashed commit message with chore:
when it goes in
34 flaky tests on run #50248 ↗︎
Details:
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/commands/querying_shadow.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/commands/log.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/commands/querying.cy.ts • 1 flaky test • 5x-driver-electron
e2e/origin/integrity.cy.ts • 1 flaky test • 5x-driver-electron
The first 5 flaky specs are shown, see all 23 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
types: | ||
- opened | ||
pull_request: | ||
types: [opened, edited] | ||
branches: | ||
- develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticing that this only runs on the develop
branch, so I'm not sure this would fix the issues on pull requrests
Additional details
Change to correct issue with Snyk scans not consistently executing on PR open events.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?