Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: SEC-688 | Update to the SCA scan action for Snyk #27614

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

cypresschris
Copy link
Contributor

Additional details

Change to correct issue with Snyk scans not consistently executing on PR open events.

Steps to test

How has the user experience changed?

PR Tasks

@astone123
Copy link
Contributor

@cypresschris can you update the title of the PR to start with chore:? Otherwise our changelog automation is going to complain

@cypresschris cypresschris changed the title SEC-688 | Update to the SCA scan action for Snyk chore: SEC-688 | Update to the SCA scan action for Snyk Aug 21, 2023
@cypresschris
Copy link
Contributor Author

Yes, done!

Copy link
Contributor

@astone123 astone123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, make sure to prefix the squashed commit message with chore: when it goes in

@cypress
Copy link

cypress bot commented Aug 21, 2023

34 flaky tests on run #50248 ↗︎

0 27947 1354 0 Flakiness 34

Details:

SEC-688 | Update to the SCA scan action for Snyk
Project: cypress Commit: 167a8c072e
Status: Passed Duration: 21:33 💡
Started: Aug 21, 2023 7:14 PM Ended: Aug 21, 2023 7:35 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  e2e/origin/commands/querying_shadow.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin shadow dom > .shadow() Output Video
Flakiness  e2e/origin/commands/log.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin log > logs in primary and secondary origins Output Video
Flakiness  e2e/origin/commands/querying.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin querying > .get() Output Video
Flakiness  e2e/origin/integrity.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
Integrity Preservation > <script> tags > preserves integrity with static <script> in HTML with SHA256 integrity. Output Video

The first 5 flaky specs are shown, see all 23 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypresschris cypresschris merged commit 1f1e39e into develop Aug 21, 2023
85 of 88 checks passed
@cypresschris cypresschris deleted the SEC-688 branch August 21, 2023 20:26
types:
- opened
pull_request:
types: [opened, edited]
branches:
- develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticing that this only runs on the develop branch, so I'm not sure this would fix the issues on pull requrests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants