feat(webpack-dev-server): update the generated tsconfig path for angular CT - #27723
Merged
jordanpowell88 merged 5 commits intoSep 6, 2023
Merged
Conversation
jordanpowell88
changed the title
astone123
approved these changes
Aug 31, 2023
astone123
left a comment
astone123
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me. Will be good for Nx users to be able to run CT in parallel.
5 flaky tests on run #50835 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > with `times` > only uses each handler N times |
Output
|
|
| network stubbing > intercepting response > can throttle a proxy response using res.setThrottle |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
Review all test suite changes for PR #27723 ↗︎
dkasper-was-taken
approved these changes
Sep 6, 2023
jordanpowell88
deleted the
jordanpowell88/update-angular-tsconfig-path
branch
September 6, 2023 18:47
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
This changes is needed so that Nx users can execute
component-testtasks inparallel. This is a Huge performance blocker at the moment. This PR in version 13 unblocked users from doing this forReact. However, this PR is needed to support this behavior for Angular (in addition to the other PR).Essentially when Component Testing for Angular is launched we generate a
tsconfigfile on the fly in a temp directory that gets passed to the Angular builder. The builder returns awebpackconfig which we use in ourwebpack-dev-server. The issue is that when Nx users try to run inparallelthe generatedtsconfigfile gets overwritten in the same path. This PR generates the temporarilytsconfigin a unique path based upon theprojectRootname.Steps to test
How has the user experience changed?
No changes are made to the current UX. The change is that it now allows users with Nx to run in CT tests in parallel.
PR Tasks
cypress-documentation?type definitions?