Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support proxy correlation timeout notifications and additional proxy data #27976

Merged
merged 17 commits into from Oct 10, 2023

Conversation

ryanthemanuel
Copy link
Collaborator

Additional details

Support proxy correlation timeout notifications and additional proxy data. Specifically we will be:

  • Adding a new app -> protocol method that notifies the protocol that a given request has timed out in terms of proxy correlation. We throw an error in this case (after updating the DB) so that we can be notified of these occurrences
  • Communicate for all requests
    • The client time for the network requests
    • The server time when the cdp events for a given network request were received
    • The lag between the client time and server time for the cdp events
    • The time that the proxy received the request
    • The time to correlate (i.e. the difference between the server time for the cdp event and the time that the proxy received the request)

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

@cypress
Copy link

cypress bot commented Oct 5, 2023

32 flaky tests on run #51556 ↗︎

0 28144 1345 0 Flakiness 32

Details:

Update packages/server/lib/cloud/protocol.ts
Project: cypress Commit: 934c08f7be
Status: Passed Duration: 19:39 💡
Started: Oct 10, 2023 6:30 PM Ended: Oct 10, 2023 6:50 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
... > automatically parses application/json request bodies Output
Flakiness  e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  project-setup.cy.ts • 2 flaky tests • launchpad-e2e

View Output Video

Test Artifacts
... > can skip setup CT testing for an E2E project Test Replay Output Screenshots
Launchpad: Setup Project > switch testing types > takes the user to first step of e2e setup when switching from app Test Replay Output Screenshots
Flakiness  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > can be opened Test Replay Output Screenshots

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

Review all test suite changes for PR #27976 ↗︎

@ryanthemanuel ryanthemanuel merged commit 078dc0a into develop Oct 10, 2023
79 of 82 checks passed
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/support-timeouts-and-proxy-data branch October 10, 2023 21:19
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 11, 2023

Released in 13.3.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants