Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use env to override branch instead of cli arg #28057

Merged
merged 5 commits into from
Oct 16, 2023
Merged

chore: use env to override branch instead of cli arg #28057

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8797bd4
chore: use env to override branch instead of cli arg
astone123 Oct 13, 2023
580a7ef
empty commit to build a new binary
astone123 Oct 13, 2023
793c3eb
Merge branch 'develop' into astone123/fix-linux-prereleases
astone123 Oct 13, 2023
5e8831d
empty commit to fix percy
astone123 Oct 16, 2023
3011297
Merge remote-tracking branch 'refs/remotes/origin/astone123/fix-linux…
astone123 Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions cli/scripts/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
const _ = require('lodash')
const path = require('path')
const shell = require('shelljs')
const minimist = require('minimist')

const fs = require('../lib/fs')

// grab the current version and a few other properties
Expand Down Expand Up @@ -72,9 +70,7 @@ function makeUserPackageFile (branchName) {
module.exports = makeUserPackageFile

if (!module.parent) {
const args = minimist(process.argv)

makeUserPackageFile(args.branch)
makeUserPackageFile(process.env.BRANCH)
.catch((err) => {
/* eslint-disable no-console */
console.error('Could not write user package file')
Expand Down