fix: fix failures and correlation in proxy

[ryanthemanuel]

Additional details

We recently made a change to clean up browser prerequests when requests are aborted, but we don't do the same thing with proxy prerequests. This PR ensures that we clean things up on both sides.

Steps to test

I added some integration tests to cover if CDP failures come in first vs. proxy failures.

How has the user experience changed?

n/a

PR Tasks

• Have tests been added/updated?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress]

35 flaky tests on run #51821 ↗︎

0

28150

1345

0

35

Details:

Merge branch 'develop' into ryanm/fix/proxy-fun
Project: cypress	Commit: fbc266d394
Status: Passed	Duration: 19:02 💡
Started: Oct 23, 2023 8:39 PM	Ended: Oct 23, 2023 8:59 PM

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test		Artifacts
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output
... > correctly returns currentRetry		Output

  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test		Artifacts
... > correctly returns currentRetry		Test Replay Output
... > correctly returns currentRetry		Test Replay Output
... > correctly returns currentRetry		Test Replay Output

  e2e/origin/snapshots.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test		Artifacts
cy.origin - snapshots > e2e log verification > Does not take snapshots of XHR/fetch requests from secondary origin if the wrong origin is visited / origin mismatch, but instead the primary origin (existing behavior)		Test Replay Output

  scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test		Artifacts
scaffolding component testing > react-vite-ts-unconfigured > scaffolds component testing for React and Vite		Test Replay Output Screenshots

  project-setup.cy.ts • 4 flaky tests • launchpad-e2e

View Output Video

Test		Artifacts
... > can reconfigure config after CT has been set up		Test Replay Output Screenshots
... > skips the setup steps when choosing component tests to run		Test Replay Output Screenshots
Launchpad: Setup Project > openLink > opens docs link in the default browser		Test Replay Output Screenshots
Launchpad: Setup Project > switch testing types > takes the user to first step of e2e setup when switching from app		Test Replay Output Screenshots

The first 5 flaky specs are shown, see all 20 specs in Cypress Cloud.

Review all test suite changes for PR #28094 ↗︎

[cacieprins]

This coercion is needed because ctx is HttpMiddlewareCtx<any>, which causes ctx to be any.

Removing this templated any results in a couple of typescript errors that may be indicative of bugs; one of which is in deferSourceMapRewrite which should be returning a string instead of void (unless the fn definition on L#320 is more correct than the type definition on L#68). Can resolving the ambiguous definition of ctx be rolled into this PR, or is that out of scope?

[ryanthemanuel]

I think at this point given I want to try and get this in for tomorrow, that I'll call this out of scope for now. It's a good find though. This can definitely be cleaned up at some point.

[cypress-bot]

Released in 13.3.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.3, please open a new issue.