Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass undefined to test:before:after:run:async if there isn't a next test #28213

Merged
merged 8 commits into from Nov 2, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Nov 1, 2023

Additional details

Updated the test:before:after:run:async event to not pass nextTestHasTestIsolationOn if there isn't a next test (i.e. it's the last test).

Steps to test

How has the user experience changed?

PR Tasks

@mschile mschile changed the title Mschile/test before after run async fix: pass undefined to test:before:after:run:async if there isn't a next test Nov 1, 2023
Copy link

cypress bot commented Nov 1, 2023

Passing run #52073 ↗︎

0 668 1 0 Flakiness 0

Details:

Merge branch 'develop' into mschile/test-before-after-run-async
Project: cypress Commit: 08acec70ce
Status: Passed Duration: 07:31 💡
Started: Nov 2, 2023 7:50 PM Ended: Nov 2, 2023 7:58 PM

Review all test suite changes for PR #28213 ↗︎

cli/CHANGELOG.md Outdated Show resolved Hide resolved
@mschile mschile merged commit 969d28c into develop Nov 2, 2023
89 of 93 checks passed
@mschile mschile deleted the mschile/test-before-after-run-async branch November 2, 2023 20:23
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 8, 2023

Released in 13.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants