feat: display an activity indicator in the CLI output when uploading artifacts to cypress cloud #28277
Conversation
…ask for upload order
cacieprins
changed the title
5 flaky tests on run #52378 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| src/cy/commands/storage > #getAllLocalStorage > gets local storage from all origins |
Test Replay
|
|
e2e/origin/commands/storage.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| cy.origin storage > .getAllLocalStorage |
Test Replay
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
|
|
| ... > correctly returns currentRetry |
Test Replay
|
|
| ... > correctly returns currentRetry |
Test Replay
|
|
Review all test suite changes for PR #28277 ↗︎
| @@ -150,8 +143,8 @@ export const normalizeStdout = function (str: string, options: any = {}) { | |||
| // 15 seconds -> XX seconds | |||
| .replace(/((\d+ minutes?,\s+)?\d+ seconds? *)/g, replaceTime) | |||
| .replace(/\r/g, '') | |||
| // replaces multiple lines of uploading screenshots & results (since order not guaranteed) | |||
| .replace(/(Uploading Screenshots & Videos.*?\n\n)((.*-.*[\s\S\r]){2,}?)(\n\n)/g, replaceUploadingResults) | |||
There was a problem hiding this comment.
This mask was no longer in used, so replaced with the activity mask
There was a problem hiding this comment.
The animation looks great.
@cacieprins Could we have the 'Uploading' text indented 2 spaces like the other text? Maybe in the same Blue style?
I also wonder if there should be some interval before printing the 'Uploading Cloud Artifacts: .' text, where it will just skip this if it uploads so fast. Most of my run just had this line printed arbitrarily when the upload was instant.
|
@cacieprins Mine has the Uploading displaying without a spaced line above it from the Test Replay output, not like shown in your screenshots. 
|
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Additional details
When uploading large artifacts to the cloud, we need a keep alive signal for CI systems, as well as an indicator for users when running in record mode locally.
Steps to test
How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?