fix: Add Chromium flag to disable-component-extensions-with-background-pages - #28294
Merged
Merged
Conversation
3 flaky tests on run #52235 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Test Replay
|
|
| ... > correctly returns currentRetry |
Test Replay
|
|
| ... > correctly returns currentRetry |
Test Replay
|
|
Review all test suite changes for PR #28294 ↗︎
chrisbreiding
approved these changes
Nov 13, 2023
cacieprins
approved these changes
Nov 13, 2023
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Pass flag to "Disable default component extensions with background pages - useful for performance tests where these pages may interfere with perf results."
Component Extensions doc
I noticed this as a flag passed to puppeteer and also a flag recommended in the common tooling flags for Chrome.
Perhaps it might reduce some background traffic?
Steps to test
See a passing test suite
How has the user experience changed?
Unsure if this will improve performance or not
PR Tasks
cypress-documentation?type definitions?