misc: persist upload timings to cy cloud #28418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli/CHANGELOG.md
Outdated
|
|
||
| _Released 12/5/2023 (PENDING)_ | ||
|
|
||
| **Features:** |
There was a problem hiding this comment.
This feels like a misc task that users don't care about. I wouldn't flag this as a feature since it's internal to us.
There was a problem hiding this comment.
updated in 9badcb4
packages/server/lib/modes/record.js
Outdated
| // performance.now() gives milliseconds with many decimals - this is | ||
| // higher resolution than we need, and the cy cloud column is int, not | ||
| // a floating poina | ||
| uploadDuration: Math.round(performance.now() - startTime), |
There was a problem hiding this comment.
can we change this from duration to upload duration ? does this create an new column in the DB ?
There was a problem hiding this comment.
The new column has already been created in the DB, and the api schema has this field as uploadDuration
cacieprins
changed the title
chrisbreiding
requested changes
Nov 28, 2023
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
chrisbreiding
approved these changes
Nov 29, 2023
emilyrohrbough
approved these changes
Nov 29, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instances/:id/artifacts#28238Additional details
To more effectively monitor the duration of uploading artifacts to cy cloud, we now record that duration when finalizing artifact uploads.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?